Implementation of E-Invoice and discrepancies between PDF and XML about invoiceninja HOT 3 OPEN

@LarsK1

Looking here:

if (isset($item->task_id)) {
    $this->xrechnung->setDocumentPositionQuantity($item->quantity, "HUR");
} else {
    $this->xrechnung->setDocumentPositionQuantity($item->quantity, "H87");
}

Perhaps instead of checking if task_id is set, we can use type_id

'1' == product
'2' == service

I think this would work better than relying on task, also, i believe isset($task_id) will always return true.

@ddomhoff thanks for raising these points. We've been discussing how we can handle e-invoices better. I believe the best solution here is to provide a mapping of Invoice Ninja fields => EInvoice fields so that users can customize the exact fields required for their purpose. It is on my list of things to do.

from invoiceninja.

Thanks for your reply and sorry for not going more into the code before submitting.

We do not use tasks/time tracking, so I guess you are right and this part is just not working as intended. But would there be a frontend representation of type_id?

from invoiceninja.

@turbo124 @ddomhoff I checked in a fix for the amount. The payment means are way more diffuclt to solve properly... Maybe @turbo124 will implement it in a future feature branch

from invoiceninja.