Code Monkey home page Code Monkey logo

Comments (6)

hillelcoren avatar hillelcoren commented on May 13, 2024

If you don't have any recurring invoices we do hide the section. We'd like to make improvements to this page in the future.

The invoice staying in draft state is a bug. It looks like we're only updating the state if the client pays the invoice, if the payment is entered manually we're not updating it.

I'll work on a fix along with a query to correct existing data. Thanks for reporting this.

from invoiceninja.

peterquentin avatar peterquentin commented on May 13, 2024

Regarding invoice status on entering a manual payment:

In file: app\ninja\repositories\PaymentRepository.php

In the public function save find:

$payment->transaction_reference = trim($input['transaction_reference']);
$payment->save();

Add this code after that line:


$invoice = $payment->invoice()->firstOrFail();
$invoice->invoice_status_id = ($amount < $invoice->balance) ? INVOICE_STATUS_PARTIAL : INVOICE_STATUS_PAID;
$invoice->save();

This should be refactored to its own responsibilty, but if you need it now you can use it 👍

from invoiceninja.

hillelcoren avatar hillelcoren commented on May 13, 2024

@peterquentin

Thanks for the fix. I've added your code to the activity handler so it will be applied for all payments.

from invoiceninja.

whitebook avatar whitebook commented on May 13, 2024

I have a new commit that adds BS3 Accordian to invoices page. Also on the Quotes Controller I removed the recurring lnvoice list on top because thats not relevant.
https://github.com/whitebook/invoice-ninja/blob/db38d496bec182afe65743bd2806395f441c0955/app/views/list.blade.php

from invoiceninja.

hillelcoren avatar hillelcoren commented on May 13, 2024

Very cool, thanks for sharing this change!

from invoiceninja.

whitebook avatar whitebook commented on May 13, 2024

Perhaps a Tab is more appropriate.

from invoiceninja.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.