Code Monkey home page Code Monkey logo

Comments (14)

bozzmob avatar bozzmob commented on July 20, 2024

I wanted to know, what does - " Drawer menu items are not centered" exactly mean?

I see the menu is using the center property. And as per the padding and other css property, in the demo app, it looks pretty ok.

<View style={styles.item}>
    <Icon
        name={icon}
        color={'rgba(0,0,0,.54)'}
        size={22}
        style={styles.icon}
    />
    <View style={styles.value}>
        <Text style={[TYPO.paperFontBody2, { color: 'rgba(0,0,0,.87)' }]}>
            {value}
        </Text>

    </View>
</View>

Style-

item: {
        flex: 1,
        flexDirection: 'row',
        alignItems: 'center',
    },

from react-native-material-design.

Ehesp avatar Ehesp commented on July 20, 2024

The line height is off:

image

The icons horizontal does not match with the texts horizontal path.

from react-native-material-design.

bozzmob avatar bozzmob commented on July 20, 2024

Can you please tell me what does - "Drawer menu items should support labels" mean?
I would like to finish up the Drawer enhancements and features, which are like 4 of the tasks.

Basically I am looking forward to be an active contributor to this repo. Would like to help you/your plan in releasing faster :)

from react-native-material-design.

Ehesp avatar Ehesp commented on July 20, 2024

Sure, it's not actually in the spec on the website, however they are:

image

Good place to see them is in the GMail app.

from react-native-material-design.

bozzmob avatar bozzmob commented on July 20, 2024

Got it! :) Thanks for the info.

from react-native-material-design.

Ehesp avatar Ehesp commented on July 20, 2024

Updated!

from react-native-material-design.

bozzmob avatar bozzmob commented on July 20, 2024

Can you shed some light on - "Drawer should respond to theme changes correctly"? What exactly should happen in this?

from react-native-material-design.

bozzmob avatar bozzmob commented on July 20, 2024

Are you referring to changing the image to colour? The image looks good. Doesn't it? And moreover in the spec I see image there.

Image

from react-native-material-design.

Ehesp avatar Ehesp commented on July 20, 2024

So you can pass a THEME into the drawer, light and dark. If it's dark the background would be the dark grey color and the text & icons white. Right now the variables are hard coded, so they'd need to adapt to the theme just like Buttons, Checkboxes etc. But yes the image does need changing too.

from react-native-material-design.

bozzmob avatar bozzmob commented on July 20, 2024

Just one final clarification, "If it's dark the background" would mean, if the colour is DARK GREEN or DARK BLUE(etc.,), then, the Drawer's list should switch colour to dark grey background with white fonts & white text?

from react-native-material-design.

Ehesp avatar Ehesp commented on July 20, 2024

It should follow the spec here - I believe the light theme might need some tweaks too.

image

from react-native-material-design.

bozzmob avatar bozzmob commented on July 20, 2024

Hi @Ehesp , I am not sure I can take up the Theme feature for now. But, I would like to give a try on - "Drawer menu items should be broken into sections to allow for proper padding". What sections are we referring to exactly? The components and Config are the 2 sections available right now.

from react-native-material-design.

Ehesp avatar Ehesp commented on July 20, 2024

This has now been done... This one is means that the menu items on the nav drawer are spaced incorrectly. They each have their own margin, but infact they should be broken into groups which have margin, but the items themselves do not.

from react-native-material-design.

bozzmob avatar bozzmob commented on July 20, 2024

Woohoo! I guess we are almost in a pretty good shape now! Matter of time, 0.3.0 will be out I guess.

from react-native-material-design.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.