flask_sqlalchemy_session support? about flask-security-fork HOT 9 CLOSED

Closed via 731958c

from flask-security-fork.

It looks fine. Just make sure that you include tests and docs. Thanks!

from flask-security-fork.

Unfortunately, I couldn't figure out why the test is not passing.

`
| assert datastore.add_role_to_user(user, 'editor') is True
| > assert datastore.add_role_to_user(user, 'editor') is False
| E assert True is False

`

@illume Does the method add_role_to_user work for you?

from flask-security-fork.

@krahser note, the SQLAlchemyUserDatastore had some changes too. Thanks heaps for doing this!

from flask-security-fork.

Yes, I saw that, but it's not necessary. If you make the query as is defined it works too.
Just to be sure I test both ways and I get the same error.

from flask-security-fork.

I realize that the mistake was in the backref definition on the user model.

It's alredy pushed. Now all the tests pass and It's also the beginning of docs in my fork.
I hope to finish this tomorrow.

from flask-security-fork.

I made some changes here: https://github.com/illume/flask-security-fork/tree/flask_sqlalchemy_session

There was some failures with old versions of flask-sqlalchemy. http://stackoverflow.com/questions/20201809/sqlalchemy-flask-attributeerror-session-object-has-no-attribute-model-chan

I added a fix for that in the branch. All the tests pass on travis now.

from flask-security-fork.

Cool. I'll leave the rest to you. See "def commit" here: https://github.com/illume/flask-security-fork/tree/flask_sqlalchemy_session

from flask-security-fork.

Thanks!

from flask-security-fork.