Code Monkey home page Code Monkey logo

Comments (6)

JonasKs avatar JonasKs commented on June 18, 2024

Hi! Yes, I agree. I actually did this with a project using AWS Cognito auth this weekend.

I’m very happy to accept a pull request on this 😊

from fastapi-azure-auth.

JonasKs avatar JonasKs commented on June 18, 2024

Hi @robteeuwen , would you like to submit a PR? 😊

from fastapi-azure-auth.

robteeuwen avatar robteeuwen commented on June 18, 2024

I do, but I need a little bit of time to format my code. I made multiple changes that I have to pull apart.

from fastapi-azure-auth.

JonasKs avatar JonasKs commented on June 18, 2024

No worries - let me know if you need any help! 😊

from fastapi-azure-auth.

robteeuwen avatar robteeuwen commented on June 18, 2024

I'm having some trouble with the tests. I'm pretty sure the code itself works fine, at least within the context I need it for (I've tested it in the dev environment of my organization and my local environment). I noticed that the mock keys that are used for the tests (in build_openid_keys() in utils.py) only had placeholders for n and e fields, so adding the real values based on the cert fixed some failing tests. However, some tests are currently still failing because the signature can't be verified for some reason. Not sure what's going wrong there, but feel free to take a look at my fork.

from fastapi-azure-auth.

JonasKs avatar JonasKs commented on June 18, 2024

Awesome! I’ll look this week. Could you create a PR so I can contribute to your fork?

from fastapi-azure-auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.