Compilation fails with boost 1.58.0 and clang 4.0.1 about hyperscan HOT 4 CLOSED

Thanks for pointing this out. We do test older versions of boost, but also need to test that against a wider range of compilers.

This is only a warning, so we can wait to fix this in the next release. We don't enable -Werror for default builds (RelWithDebInfo) - so that newer/different compilers don't cause unnecessary failures - but do enable it for CMAKE_BUILD_TYPE=Debug builds for use in development.

from hyperscan.

I was compiling a Debug build.
It should be trivial to only enable this for clang and GCC. Let me know I can update the PR.

from hyperscan.

Looking at it a little more: for this particular case it makes more sense to test the compiler for the presence of the warning flag, and then apply it only when building the unit tests - just as we have in CMakeLists.txt and unit/CMakeLists.txt for the use of -Wno-unused-variable. That means it should work on whichever compiler can generate that warning.

(It is more a pity that this isn't a warning that can be ignored by using -isystem on Boost headers - the problem is that macro is expanded in our code, not the header, so -isystem doesn't save us.)

We shouldn't be disabling this warning generally - we want to pick up if we have this in our code base. Whether we have -Werror for all public builds is something else we will consider.

from hyperscan.

Ok, I will change the PR to follow suit.

from hyperscan.