Code Monkey home page Code Monkey logo

Comments (4)

Frakette avatar Frakette commented on May 27, 2024

I have an issue too using '@react-native-community/slider' as sliderComponent. I don't get a crash but i think there is indeed an issue with the typechecking of sliderComponent props.
Here's an extract of my code :
<ColorPicker
style={{ flex: 1 }}
defaultColor={newColor}
onColorChange={color => setNewColor(fromHsv(color))}
// not working for now - seems to be an error in code of the package - see latest issue in package
sliderComponent={(props: any) => (
<SliderComponent
value={props.value}
onValueCange={() => props.onValueChange()}
/>
)}
/>

My SliderComponent get the value prop.
However, the onValueChange prop doesn't seem to work because when I slide, none of the "v" / "s" value are changing.

from react-native-color-picker.

Hektar90 avatar Hektar90 commented on May 27, 2024

@Frakette Do you use typescript in your project?
This is just a type error issue which means it compiles and works. Only my IDE is complaining.

SliderComponent isn't customized, is it? So just add the component class like so:

<ColorPicker ...sliderComponent={SliderComponent }

this should work if i get you right

from react-native-color-picker.

Frakette avatar Frakette commented on May 27, 2024

@Hektar90 Yes I use typescript on my project. Actually my issue might not be fully related to yours but I also see a Typescript error when I try to add a sliderComponent.

I was struggling to pass props to my SliderComponent because I was passing it directly as a component and it was not working but as a function that returns a component it works although the slider is a bit glitchy.

However, as you noticed, I still get get the same Typescript error than you when passing SliderComponent.
I ended up using a //@ts-expect-error to avoid compilation errors. But a correction on the type checking would be great :)

from react-native-color-picker.

gprinc-hu avatar gprinc-hu commented on May 27, 2024

Any update in this issue? I have the same problem

from react-native-color-picker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.