Code Monkey home page Code Monkey logo

Comments (3)

kitbs avatar kitbs commented on May 30, 2024 1

@tylernathanreed

I see what you mean. I've just pushed a commit to add the method labelUsing which accepts a callback.

Url::make('Homepage')
    ->labelUsing(function($value, $resource) {
        return $this->title;
    }),

I've got a few more improvements to make tonight so I'll create a release soon.

from nova-url-field.

kitbs avatar kitbs commented on May 30, 2024

Hi @tylernathanreed

Could you try something like this?

Url::make('Homepage', 'model_attribute_for_url')
    ->label($this->model_attribute_you_want_as_label),

from nova-url-field.

tylernathanreed avatar tylernathanreed commented on May 30, 2024

@kitbs,

That would only work in limited scenarios. The field declarations is typically done with an empty resource, so the "$this" scope isn't called for each resource. This is why Nova uses a closure.

I would expect this sort of functionality to work:

Url::make('Homepage', 'model_attribute_for_url')
    ->label(function() {
        return $this->model_attribute_you_want_as_label;
    }),

As that is how Nova expects computed properties to behave.

However, this package doesn't currently support passing in a closure for labels.

from nova-url-field.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.