Update to base16 0.9.1 about base16-builder-python HOT 8 CLOSED

Okay, so the builder shouldn't hang anymore when there's an issue with a single thread (96383d0).

from base16-builder-python.

Same error here on arch with Python 3.7.4.

I get the error on a different colorscheme. I tried to remove the faulty one and build it again, but still got the same error. Just on a different colorscheme.

from base16-builder-python.

@reneatzi I suspect that the thread that's throwing the error isn't processing the theme whose name was printed on the previous line; there could well be quite a few threads running at once, and that error could have come from any of them. I've not checked the code though - this is just how I imagine it's working. Perhaps we should grep for #2 to narrow down the potential culprits (I'm not on the right computer right now to try it).

from base16-builder-python.

First of all, thanks for reporting!
There's two things here that need to be considered. First, why does building fail for some schemes and then, why does a build error cause the script to hang.

So for the first part, my initial guess would be that these are schemes that adhere to the new base16 standard (0.9.1) which the builder doesn't support yet. Regarding the hanging issue, I had a quick look at the code and I am pretty sure, the program blocks because the thread doesn't signal task_done() to the queue when it encounters an exception. That should be easy to fix. Updating the builder to 0.9.1 actually shouldn't be that difficult either, but might take a little time. I'll try to fix that in the coming week or so.

from base16-builder-python.

Nicely, thanks @InspectorMustache. I just updated, ran it again, and got your nice helpful error message instead...

Error building /home/graham/tmp/base16/base16-builder-python/schemes/gigavolt/gigavolt.yaml:
	invalid literal for int() with base 16: '#2'Building colorschemes for scheme "Brogrammer"…

I think can do without the Brogrammer... ;-)

from base16-builder-python.

Okay, so the builder shouldn't hang anymore when there's an issue with a single thread (96383d0).

Thank you, can confirm that it is working now.

from base16-builder-python.

Good to hear, I changed the title of the issue to better reflect what's still left to do.

from base16-builder-python.

Actually this had nothing to do with the update to the base16 specification, that scheme is just badly formatted. Aaaaanyway....

from base16-builder-python.