Code Monkey home page Code Monkey logo

Comments (4)

jhlegarreta avatar jhlegarreta commented on August 16, 2024 1

Re #4748 (comment)

I am not bumping to newer ITK versions when transitioning to pyproject.toml: I am leaving unmodified the ITK dependency version that is transferred automatically from setup.py to pyproject.toml. Do you want me to require "itk>=5.4" for all of them while adopting pyproject.toml?

In the process of updating these, we could consider also changing the default branch from master to main,

Can do that right after the PRs are merged.

from itk.

thewtex avatar thewtex commented on August 16, 2024

@jhlegarreta thank you for your help with this! 💯 🥇

I did not bump the versions for the remotes while opening the PRs. @thewtex let me know your thoughts. Major, minor, patch, none?

I think we should bump the major version. Experience has shown that the packages are not binary compatible across itk major or minor releases. Following semantic versioning, this is a major bump.

In the process of updating these, we could consider also changing the default branch from master to main,

image

from itk.

thewtex avatar thewtex commented on August 16, 2024

I am not bumping to newer ITK versions when transitioning to pyproject.toml: I am leaving unmodified the ITK dependency version that is transferred automatically from setup.py to pyproject.toml. Do you want me to require "itk>=5.4" for all of them while adopting pyproject.toml?

Yes, please. itk == 5.4.* to be specific (or itk-core == 5.4.* if it only requires itk-core, etc.) We should update the script to do so automatically, too.

from itk.

jhlegarreta avatar jhlegarreta commented on August 16, 2024

Yes, please. itk == 5.4.* to be specific (or itk-core == 5.4.* if it only requires itk-core, etc.) We should update the script to do so automatically, too.

OK, done. The script does update to itk == 5.4.* in most cases (e.g. it does not when no specific version of itk has been specified, for example).

Edit: leaving bumping version of ITKTubeTK to @aylward.

from itk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.