ITK failed to build in Visual Studio 2022 due to error C2187, C2938 and C2532 about itk HOT 10 CLOSED

@N-Dekker Thanks for your response, I updated the commit, it passed.

from itk.

We use the unreleased VS2022.

from itk.

Thank you for contributing an issue! 🙏

Welcome to the ITK community! 🤗👋☀️

We are glad you are here and appreciate your contribution. Please keep in mind our community participation guidelines. 📜
Also, please check existing open issues and consider discussion on the ITK Discourse. 📖

from itk.

Visual Studio 2017 is no longer a supported compiler. See this discussion.

from itk.

@dzenanz We are using Visual Studio 2022, not 2017

from itk.

VS2022 is tested nightly. The build errors must be due to non-default parameters. If you isolate the one causing the problem, it will be easier for whoever attempts to fix it.

from itk.

Example build: https://open.cdash.org/build/8783171

from itk.

@dzenanz When compiling the itkPointGTest.cxx file, it causes these problems.
Command: "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.35.32215\bin\HostX64\x64\CL.exe" /c /IF:\gitP\InsightSoftwareConsortium\ITK\build_amd64\Modules\ThirdParty\Eigen3\src /IF:\gitP\InsightSoftwareConsortium\ITK\build_amd64\Modules\ThirdParty\KWSys\src /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\ThirdParty\VNL\src\vxl\v3p\netlib /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\ThirdParty\VNL\src\vxl\vcl /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\ThirdParty\VNL\src\vxl\core /IF:\gitP\InsightSoftwareConsortium\ITK\build_amd64\Modules\ThirdParty\VNL\src\vxl\v3p\netlib /IF:\gitP\InsightSoftwareConsortium\ITK\build_amd64\Modules\ThirdParty\VNL\src\vxl\vcl /IF:\gitP\InsightSoftwareConsortium\ITK\build_amd64\Modules\ThirdParty\VNL\src\vxl\core /IF:\gitP\InsightSoftwareConsortium\ITK\build_amd64\Modules\Core\Common /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Core\Common\include /IF:\gitP\InsightSoftwareConsortium\ITK\build_amd64\Modules\IO\ImageBase /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\IO\ImageBase\include /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Core\ImageAdaptors\include /IF:\gitP\InsightSoftwareConsortium\ITK\build_amd64\Modules\ThirdParty\Netlib /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Numerics\Statistics\include /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Filtering\ImageFilterBase\include /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Core\Transform\include /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Core\ImageFunction\include /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Filtering\ImageGrid\include /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Filtering\ImageCompose\include /IF:\gitP\InsightSoftwareConsortium\ITK\build_amd64\Modules\ThirdParty\ZLIB\src /I"F:\gitP\InsightSoftwareConsortium\ITK\build_amd64\Modules\ThirdParty\ZLIB\src\itkzlib-ng" /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\ThirdParty\ZLIB\src /IF:\gitP\InsightSoftwareConsortium\ITK\build_amd64\Modules\ThirdParty\MetaIO\src\MetaIO\src /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\ThirdParty\MetaIO\src\MetaIO\src /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Core\SpatialObjects\include /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Filtering\ImageStatistics\include /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Filtering\Path\include /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Filtering\ImageIntensity\include /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Core\Mesh\include /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\ThirdParty\DoubleConversion\src /I"F:\gitP\InsightSoftwareConsortium\ITK\build_amd64\Modules\ThirdParty\DoubleConversion\src\double-conversion" /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\Core\TestKernel\include /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\ThirdParty\VNL\src\vxl\core\vnl\algo /IF:\gitP\InsightSoftwareConsortium\ITK\Modules\ThirdParty\VNL\src\vxl\core\vnl /IF:\gitP\InsightSoftwareConsortium\ITK\build_amd64\Modules\ThirdParty\VNL\src\vxl\core\vnl /I"F:\gitP\bitcoin\tools\vcpkg\installed\x64-windows\include" /nologo /W3 /WX- /diagnostics:column /O2 /Ob2 /D _MBCS /D WIN32 /D _WINDOWS /D NDEBUG /D _CRT_FAR_MAPPINGS_NO_DEPRECATE /D _CRT_IS_WCTYPE_NO_DEPRECATE /D _CRT_MANAGED_FP_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _CRT_SECURE_NO_DEPRECATE /D _CRT_SECURE_NO_DEPRECATE_GLOBALS /D _CRT_SETERRORMODE_BEEP_SLEEP_NO_DEPRECATE /D _CRT_TIME_FUNCTIONS_NO_DEPRECATE /D _CRT_VCCLRIT_NO_DEPRECATE /D _SCL_SECURE_NO_DEPRECATE /D "CMAKE_INTDIR="Release"" /Gm- /EHsc /MD /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /std:c++17 /Fo"ITKCommonGTestDriver.dir\Release\" /Fd"ITKCommonGTestDriver.dir\Release\vc143.pdb" /external:W0 /Gd /TP /errorReport:queue /external:I "F:/gitP/InsightSoftwareConsortium/ITK/Modules/ThirdParty/Eigen3/src/itkeigen/.." /external:I "F:/gitP/InsightSoftwareConsortium/ITK/Modules/ThirdParty/GoogleTest/src/itkgoogletest/googletest/include" /external:I "F:/gitP/InsightSoftwareConsortium/ITK/Modules/ThirdParty/GoogleTest/src/itkgoogletest/googletest" /bigobj F:\gitP\InsightSoftwareConsortium\ITK\Modules\Core\Common\test\itkPointGTest.cxx

from itk.

Thanks for reporting this issue, @Eva-An Looks like this is the same problem that Dženan reported last week:

• #4153

It should be addressed now, by commit 89d3c3c, from the following pull request:

• #4154

It appears that these errors are caused by a recently introduced Visual C++ compiler bug. Please check (and vote for it!): https://developercommunity.visualstudio.com/t/error-C2187-syntax-error:-attribute-sp/10439022

Please close the issue if you agree 😃

from itk.

Thanks for closing this issue @Eva-An I'm still curious how you could have found this issue already on June 16, while the MSVC compiler bug that caused the issue was only "officially released" on August 8 (with VS2022 version 17.7)! Did you use some kind of beta or pre-release of VS2022?

from itk.