vnl_matrix multiple definitions about itk HOT 5 CLOSED

I can reproduce this locally on my computer, but I don't know why the multiple definition is even invoked for this inline constructor of a template class. Adding inline specifier to the constructor does not fix the error.

from itk.

@dzenanz FYI: All my windows builds are failing at
Error C1083 Cannot open include file: 'itkeigen/Eigen/Eigenvalues': No such file or directory ITKCommon d:\src\itk\modules\core\common\include\itksymmetriceigenanalysis.h 23

I can not even get ITKCommon to build. Sorry, but I won't be able to look at this right away.

As a quick fix, can you move the definition of vnl_matrix()

from the header to .hxx file?

template
vnl_matrix::vnl_matrix () :
num_rows(0),
num_cols(0),
data(nullptr)
{ }

from itk.

I'm testing this build on mac. So it's not a very good test:

diff --git a/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_matrix.h b/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_matrix.h
index ab3c7e20a37f..72ea5fb73903 100644
--- a/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_matrix.h
+++ b/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_matrix.h
@@ -114,12 +114,7 @@ class VNL_EXPORT vnl_matrix
{
public:
//: Default constructor creates an empty matrix of size 0,0.

• vnl_matrix() :
• num_rows(0),
• num_cols(0),
• data(nullptr)
• {
• }

• vnl_matrix();

  //: Construct a matrix of size r rows by c columns
  // Contents are unspecified.
  diff --git a/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_matrix.hxx b/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_matrix.hxx
  index 50a57cb7e3ff..e249867454d8 100644
  --- a/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_matrix.hxx
  +++ b/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_matrix.hxx
  @@ -133,6 +133,15 @@ do {
  //: Creates a matrix with given number of rows and columns.
  // Elements are not initialized. O(m*n).

+template
+vnl_matrix::vnl_matrix () :

• num_rows(0),
• num_cols(0),
• data(nullptr)
• {
• }

template
vnl_matrix::vnl_matrix (unsigned rowz, unsigned colz)
: num_rows(rowz), num_cols(colz)

from itk.

@dzenanz Would you be able to test this? I can't get any windows builds working. I keep running into a problem related to missing Eigen headers long before I get to your problem.

from itk.

OK I am testing what happens when the constructor's definition is moved from .h into .hxx file.

from itk.