Type errors on WebSocket Factory about rxjs-websockets HOT 5 CLOSED

I think the types for this library also need to improved though... maybe ws is onto something.

from rxjs-websockets.

The types being used are the native types, ws is the one doing it's own thing. ws should be updated rather than this library.

from rxjs-websockets.

We either have to be stronger typed accepting only things that provide ws. Or, massively weaker typed to the common denominator between ws and w3c. At that point we're pretty much just dropping TypeScript support explicitly with any.

We can do that too if you want me to strip the types. As it is though, I don't think the factory thing works in a strongly typed system unless any contemporary node.js modules are producing the w3c types, certainly not ws which is the big one (afaik).

Not sure how other client/server code bases do it. Maybe request.js has some wisdom on it?

from rxjs-websockets.

I'm fixing this now, sorry it took so long.

from rxjs-websockets.

@EvanCarroll Linked the fixing commit to this issue, annoying I had to use any, not sure why typescript doesn't apply function bivariance when considering type compatibility of an object's properties to an interface. Released v6.0.4 with the fix.

from rxjs-websockets.