onSelect is fired on init and when the count is changed about jquery-paging HOT 9 CLOSED

Hi,

I was thinking a long time about this, when I designed the API of Paging and concluded, that this issue should be handled by the user.

As you can read off your description, your usecase is quite specific. I could imagine to introduce a new options directive which blocks the onSelect call within the library.

Could you formulate, how you would like the API to be to solve your two issues? I mean on what stages of the API interaction you would lock/unlock the callback? I don't want to introduce a single directive like "no init callback" or something as I want the library to be as generic as possible

Robert

from jquery-paging.

Hi, thanks for getting back to me so promptly, I appreciate it.

I guess that in terms of keeping things as generic as possible, the initialisation and adjustment of the count wouldn't carry with them any side effects at all. The initialisation would simply set up the pagination, so that it would be ready to interact with. A method could be called on the object returned, which would fetch the data for whatever page (1st by default). Setting a new count would change the number of pages shown in the control. To me it seems like a separate thing to fire the event in both of these cases, as neither of the methods suggest that any new data should be requested.

Perhaps it would be better if it weren't necessary to call setPage after setNumber - incidentally, I was caught out by this when first using the plugin. That way, setPage could still trigger the onSelect behaviour, whereas setNumber by itself wouldn't.

Cheers,
Tom

from jquery-paging.

In case it is useful, I resolved this in the end by setting an additional option on the pager before calling setPage():

pager.setNumber(count).setOptions({ preventRefresh: true }).setPage();

In my onRefresh callback function I then did:

if (pager.opts && pager.opts.preventRefresh === true) {
    pager.setOptions({
        preventRefresh: false
    });
    return;
}

This returns early from the function before doing the AJAX call which was causing the infinite loop.

I hope that someone else finds this useful, as I found the default behaviour quite unintuitive. Anyway, thanks for making the plugin!

Cheers,
Tom

from jquery-paging.

Hi Tom,

thanks for your work. I'll leave the ticket open and implement a standard hook for this case when I have some time for it. Sorry for my sparse communication on that.

Robert

from jquery-paging.

Hi,

I have run into this infinite loop issue when I simply want to do to redirect with the onSelect method. Reading above I see that this gets call on init() and probably why I am stuck in an infinite loop. For example my onSelect is the following function:

function (page) { window.location.replace(url+page) }

where url is path to a page. As you can see since the default page has this code on it, then it will infinitely loop. Any help will be appreciated.

James

from jquery-paging.

I figure out a solution, which was to check the complete window.location.href variable in order to determine whether the new url with the page parameter from onSelect function was the same as the current page href. If so, then it must have been an init of the page through some other method outside of clicking the pagination plugin.

from jquery-paging.

But it's not work when you use post ajax requests and window.location.href is same.
Anyway, I think we need additional option to fire or not to fire onSelect at init.

from jquery-paging.

Could you please provide a jsfiddle or pastebin?

from jquery-paging.

I don't understand last question for me? Provide which part of what? Anyway, I have resolved problem myself.

from jquery-paging.