Build on windows failed ( > node 18.x.x) about node-bindgen HOT 6 CLOSED

Hi, @DmitryAstafyev, windows are not the first tier we support. It was done by another contributor a while back.
@simlay can you take look?

from node-bindgen.

full_link_err.log

from node-bindgen.

@sehz hello there ) any ideas about this issue?

from node-bindgen.

Probably an issue is here: node-bindgen/nj-build/src/lib.rs

if !temp_lib.exists() {
        let lib_file_download_url = format!(
            "https://nodejs.org/dist/{}/win-x64/node.lib",
            node_full_version
        );

        println!(
            "downloading nodejs: {} to: {:#?}",
            lib_file_download_url, temp_lib
        );

        let mut node_lib_file = File::create(&temp_lib).unwrap();
        request::get(&lib_file_download_url, &mut node_lib_file)
            .expect("Download node.lib file failed");
    }

probably it makes sense to check size of file, not just exists or not, but take into account a size; or (it would be more right and simpler), remove created file if downloading was failed

from node-bindgen.

hello @asv7c2 , may be you have some ideas about it? )

from node-bindgen.

@sehz @simlay hello, could you please take a look on PR - #204
the issue was trivial - url

from node-bindgen.