error after deleting node_modules and running npm i about ignite-andross HOT 8 CLOSED

Hey, I'm not following what you're saying here.

Could you rephrase it for me?

Thanks.

from ignite-andross.

To reproduce:

• Generate a default app - don't have IGNITE_PLUGIN_PATH set as an env variable
• Open package.json, the boilerplate is linked by file path instead of npm package

For example, I see "ignite-ir-boilerplate": "file:/private/tmp/ignite/MyApp/node_modules/ignite-ir-boilerplate",

from ignite-andross.

Woah! Thanks! I'm going to see if I can reproduce this here. Yikes.

Thanks for the clarification.

from ignite-andross.

Confirmed.

From my newly made package.json:

"ignite-ir-boilerplate": "file:/Users/steve/src/sandbox/ignite/Test/node_modules/ignite-ir-boilerplate",

This line is probably the cause. We need to be installing from npm, not locally.

Thanks again.

from ignite-andross.

Not so straight forward. I think we might need to introduce another switch for this. I can see some situations where you would want to install the directory.

Most of the time it should be from npm, so I do consider this a bug.

The workaround for now is to just manually change your package.json to the right answer. Sorry, I know that's lame, but we're going to have to discuss what the right solution is.

Thanks for the help guys!

from ignite-andross.

I've run into this issue as well. I do think we need a flag -- or detect when we are initially installing from a path and follow suit.

from ignite-andross.

I tested the fix and here's what I found:

• Works (from npm): ignite new MyApp -b ignite-ir-boilerplate
• Works (local clone, full path): ignite new MyApp -b /private/tmp/ignite/ignite-ir-boilerplate/
• Broken (local clone, relative path): ignite new MyApp -b ./ignite-ir-boilerplate
  • The app generates fine but the ignite add step is broken

? What animation library will you use? none
✖ /private/tmp/ignite/MyApp/MyApp/ignite-ir-boilerplate was not able to be installed. Is it a valid NPM module?
----------
Command failed: yarn add /private/tmp/ignite/MyApp/MyApp/ignite-ir-boilerplate --dev
error Couldn't find package "/private/tmp/ignite/MyApp/MyApp/ignite-ir-boilerplate" on the "npm" registry.

----------
✔ added ignite-standard in 23.48s

from ignite-andross.

Good catch! Easy enough to fix. We should just detect paths and force path to render full for us.

from ignite-andross.