Code Monkey home page Code Monkey logo

Comments (27)

MesterPerfect avatar MesterPerfect commented on May 17, 2024 1

image

from wsa-sideloader.

MesterPerfect avatar MesterPerfect commented on May 17, 2024 1

Looking great!

It would be appreciated if you could get the store listing translated as well:

https://gist.github.com/infinitepower18/526d323e8a1fd2f6307adba163aafce4

https://gist.github.com/MesterPerfect/4ac6c12fea21f28bf25151f2356c5516

from wsa-sideloader.

MesterPerfect avatar MesterPerfect commented on May 17, 2024 1

How is the accessibility support provided by pyqt or pyside?

Moving to a better framework is one of the long term plans of this project. I rather stick with a Python based framework and reuse the ADB code I wrote before as it's proven to work quite well. Right now pyqt, pyside and wxPython are my options.

I would have recommended you to use wxpython as it is the Most libraries that provide accessibility support.
However, with wxpython you will not be able to add any aesthetics to your program and you won't even be able to provide a dark mode.
So, the best option is pyqt, specifically pyqt6
It is the most well-supported version of Accessibility.
With it, you can create a beautiful look, add dark mode, and more.

from wsa-sideloader.

MesterPerfect avatar MesterPerfect commented on May 17, 2024 1

Yeah I want to add fluent design to the app to make it more in line with Windows 11, which I tried to do with the current PySimpleGUI version despite the limitations with the framework.

Using something like this, I might be able to add fluent design to the app. https://github.com/zhiyiYo/PyQt-Fluent-Widgets

These Widgets are based on pyqt5. They are good with accessibility with simple elements.
Buttons, checkboxes, radio buttons, and more
You can use it, and I will always be there to experiment accessibility with items you will use

from wsa-sideloader.

MesterPerfect avatar MesterPerfect commented on May 17, 2024 1

The redesigned app will be released as version 2.0, once I get started on it I will be releasing betas to help get it tested as well as have something for users with accessibility needs while I complete it.

great
Thank you

from wsa-sideloader.

MesterPerfect avatar MesterPerfect commented on May 17, 2024 1

Could you check both the PyQt6 and PySide6 versions of the fluent widgets to see if they meet the accessibility requirements? They are found in separate branches of the repo.

pyqt6 is very good at accessibility support
https://doc.qt.io/qtforpython-5/PySide2/QtGui/QAccessible.html

from wsa-sideloader.

infinitepower18 avatar infinitepower18 commented on May 17, 2024 1

Looks like PySimpleGUI has turned into a paid subscription service, making me accelerate my plans to move to a different framework. I will make an update post soon.

from wsa-sideloader.

infinitepower18 avatar infinitepower18 commented on May 17, 2024

Hi,

I have been told about the lack of screen reader support by another user a while ago and sadly, due to lack of screen reader support in tkinter (which PySimpleGUI is based on), it's not available in WSA Sideloader itself. I'm really sorry about this.

PySimpleGUI actually has qt and WxPython versions as well though they haven't been updated in a long time compared to the main Tkinter version. I'm seeing what I can do about this issue, whether it's best for me to switch to another version of PySimpleGUI or use a different framework altogether. A lot of the code in WSA Sideloader is specific to PySimpleGUI thus a rewrite of the UI will take a lot of time should I go with a different framework, so I cannot give a timeframe of when this will be solved.

I've been told by the other user that OCR can be used to recognise the buttons, so try using that in the meantime. If there's anything else I can do to improve accessibility, please let me know.

from wsa-sideloader.

MesterPerfect avatar MesterPerfect commented on May 17, 2024

Unfortunately, you can do nothing.
The cause of the problem is the library πŸ˜”
No problem, you can try to fix it on your own time

I have a question, I will translate tool into Arabic
Is it better to send translated JSON file via issue or via pull request

from wsa-sideloader.

infinitepower18 avatar infinitepower18 commented on May 17, 2024

Unfortunately, you can do nothing. The cause of the problem is the library πŸ˜” No problem, you can try to fix it on your own time

Wouldn't the wx version of PySimpleGUI work? Nevertheless I will ask on the GitHub once I get time

Regarding Arabic translations, you can make a pull request. But Arabic is a RTL language right? As of now I haven't accommodated RTL support in WSA Sideloader yet.

from wsa-sideloader.

MesterPerfect avatar MesterPerfect commented on May 17, 2024

@infinitepower18

Wouldn't the wx version of PySimpleGUI work?

I haven't tried it, and I don't think it offers accessibility support

Nevertheless I will ask on the GitHub once I get time

ok No problem

Regarding Arabic translations, you can make a pull request.

Yes, I will when I finish translating.

But Arabic is a RTL language right?

Yes, it is from right to left

As of now I haven't accommodated RTL support in WSA Sideloader yet.

Never mind, there are programs that have been translated into Arabic and do not support RTL
I have translated most of the file, I will try RTL

from wsa-sideloader.

infinitepower18 avatar infinitepower18 commented on May 17, 2024

Looking great!

It would be appreciated if you could get the store listing translated as well:

https://gist.github.com/infinitepower18/526d323e8a1fd2f6307adba163aafce4

from wsa-sideloader.

MesterPerfect avatar MesterPerfect commented on May 17, 2024

Looking great!

It would be appreciated if you could get the store listing translated as well:

https://gist.github.com/infinitepower18/526d323e8a1fd2f6307adba163aafce4

I translated store listing . Did you get it?

from wsa-sideloader.

infinitepower18 avatar infinitepower18 commented on May 17, 2024

Yes, will update the store listing in a while.

from wsa-sideloader.

MesterPerfect avatar MesterPerfect commented on May 17, 2024

Yes, will update the store listing in a while.

ok, you can close this issue. And if you need my help, I'm here.

from wsa-sideloader.

infinitepower18 avatar infinitepower18 commented on May 17, 2024

I will keep this open for now so I can keep track of what things to work on.

from wsa-sideloader.

MesterPerfect avatar MesterPerfect commented on May 17, 2024

I will keep this open for now so I can keep track of what things to work on.

ok

from wsa-sideloader.

infinitepower18 avatar infinitepower18 commented on May 17, 2024

How is the accessibility support provided by pyqt or pyside?

Moving to a better framework is one of the long term plans of this project. I rather stick with a Python based framework and reuse the ADB code I wrote before as it's proven to work quite well. Right now pyqt, pyside and wxPython are my options.

from wsa-sideloader.

infinitepower18 avatar infinitepower18 commented on May 17, 2024

Yeah I want to add fluent design to the app to make it more in line with Windows 11, which I tried to do with the current PySimpleGUI version despite the limitations with the framework.

Using something like this, I might be able to add fluent design to the app. https://github.com/zhiyiYo/PyQt-Fluent-Widgets

from wsa-sideloader.

MesterPerfect avatar MesterPerfect commented on May 17, 2024

Yeah I want to add fluent design to the app to make it more in line with Windows 11, which I tried to do with the current PySimpleGUI version despite the limitations with the framework.

Using something like this, I might be able to add fluent design to the app. https://github.com/zhiyiYo/PyQt-Fluent-Widgets

I will preview it with accessibility to see if it supports accessibility or not

from wsa-sideloader.

infinitepower18 avatar infinitepower18 commented on May 17, 2024

The redesigned app will be released as version 2.0, once I get started on it I will be releasing betas to help get it tested as well as have something for users with accessibility needs while I complete it.

from wsa-sideloader.

infinitepower18 avatar infinitepower18 commented on May 17, 2024

Could you check both the PyQt6 and PySide6 versions of the fluent widgets to see if they meet the accessibility requirements? They are found in separate branches of the repo.

from wsa-sideloader.

infinitepower18 avatar infinitepower18 commented on May 17, 2024

Update on future plans: #108

from wsa-sideloader.

MesterPerfect avatar MesterPerfect commented on May 17, 2024

Looks like PySimpleGUI has turned into a paid subscription service, making me accelerate my plans to move to a different framework. I will make an update post soon.

As a developer, what value do I receive by using PySimpleGUI? Are there features that justify the investment?

from wsa-sideloader.

infinitepower18 avatar infinitepower18 commented on May 17, 2024

It's a good framework for those starting out, but there's only so much you can do especially with design. I actually made a custom theme to make it look like a Windows 11 app. This was the default look which is what WSA Sideloader looked like before version 1.2:

image

Another issue was I can't set dark titlebar for dark mode. I'm hoping to solve this when I work on the new version.

from wsa-sideloader.

MesterPerfect avatar MesterPerfect commented on May 17, 2024

It's a good framework for those starting out, but there's only so much you can do especially with design. I actually made a custom theme to make it look like a Windows 11 app. This was the default look which is what WSA Sideloader looked like before version 1.2:

I attempted to use it some time ago, but due to issues and poor accessibility, I only utilized it for one day.

Another issue was I can't set dark titlebar for dark mode. I'm hoping to solve this when I work on the new version.

If you are considering using the wxPython framework, you will encounter the same issue with it, and there won't be any solutions available.

https://discuss.wxpython.org/t/dark-mode-with-wxpython-on-windows/36530

from wsa-sideloader.

infinitepower18 avatar infinitepower18 commented on May 17, 2024

Unfortunately, Microsoft has decided to discontinue Windows Subsystem for Android, so I have decided not to do the rewrite as I think it’s not worth developing for something that will no longer be supported. Sorry about that.

More info: #112

from wsa-sideloader.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.