Warnings when build project in Delphi 7 about indy HOT 14 CLOSED

I decided to go ahead and just {$IFDEF} the three values in Delphi 7 and earlier. They will get taken out anyway in Indy 11.

from indy.

How does it look now?

from indy.

Remain 1 warning:
[Warning] IdStackWindows.pas(1832): Return value of function 'TIdSocketListWindows.GetItem' might be undefined

from indy.

@GreySerg2 Which version of Delphi are you using?

@rlebeau The changes to TIdIOHandler.WriteFile and TCustomSSPIConnectionContext.UpdateAndGenerateReply actually cause (correct) warnings for me on Delphi 10.4:
[dcc32 Hint] IdIOHandler.pas(2576): H2077 Value assigned to 'TIdIOHandler.WriteFile' never used
[dcc32 Hint] IdAuthenticationSSPI.pas(1058): H2077 Value assigned to 'TCustomSSPIConnectionContext.UpdateAndGenerateReply' never used

from indy.

I wrote in Header - "Delphi 7".

from indy.

Sorry, didn't see that. Delphi 7 wasn't so good with some of these hints and could give invalid ones, for example when the code uses Result but also raises exceptions.

from indy.

If code will raise exception the return value of function will be undefined. The compiler of Delphi 7 write exactly about this. It's very easy to fix, I set result value at the beginning of function.

from indy.

Since there's no return value when an exception is raised by a function Delphi 7 is wrong, this was fixed in a later Delphi version. This is why newer versions will actually give a warning is the result value is set at the beginning anyway, as the code now does. There should be an IFDEF around the assignment.

from indy.

If I call a function with try..except and then will be work with result value of function - it will be undefined.

from indy.

Yes but this is not the case in TIdSocketListWindows.GetItem which you posted about above, nor in TIdIOHandler.WriteFile nor in TCustomSSPIConnectionContext.UpdateAndGenerateReply. They don't handle the exception so the function will raise it.

from indy.

If I call a function with try..except and then will be work with result value of function - it will be undefined.

If the caller decides to swallow an exception and use an undefined return value, that is the fault of the caller, not the callee. Even if the callee were to set its Result before raise'ing the exception, there is no guarantee that the value will reach the caller. If the caller wants to save the return value to a variable and use it even if an exception is raised, the except handler will have to assign a different value to the variable before letting the code move forward, eg:

try
  value := DoSomethingAndGetAValue();
except
  value := SomeOtherValue; // <-- here
end;
// use value as needed...

from indy.

There should be an IFDEF around the assignment.

I would really like to avoid having to do that. There are plenty of other functions throughout Indy that assign an initial Result value and then later raise an exception, and nobody complains about them warning about unused values.

Do we even know in which version of Delphi this issue was "fixed"?

I'm tempted to just revert my earlier change and let old compilers issue their warnings as before. Especially since support for old compilers is being dropped in Indy 11 anyway.

from indy.

I think you should revert the changes to TIdIOHandler.WriteFile and TCustomSSPIConnectionContext.UpdateAndGenerateReply then. The changes cause valid warnings under modern Delphi. Reverting them causes old Delphi to issues warnings again, but these warnings are not valid (and also not present in modern Delphi).

from indy.

Now all is Ok, all warnings are gone in Delphi 7.

from indy.