Code Monkey home page Code Monkey logo

Comments (10)

kecsap avatar kecsap commented on August 15, 2024

My PR will fix your problems: #262

from indi.

justanenduser avatar justanenduser commented on August 15, 2024

The -Werror flag in line 93 of CmakeLists.txt is producing the compile failure I'm reporting here.

# Verbose warnings and turns all to errors
SET(COMP_FLAGS "${COMP_FLAGS} -Wall -Wextra -Werror")

from indi.

kecsap avatar kecsap commented on August 15, 2024

Please test the latest master. My PR was merged, all gcc-7 warnings are fixed or silenced. It should build fine for you.

from indi.

justanenduser avatar justanenduser commented on August 15, 2024

from indi.

TallFurryMan avatar TallFurryMan commented on August 15, 2024

I think each time you change CMakeLists, you should remove the build folder to be on the safe side. For the 3rdparty folder, the same change as in libindi was pushed and I suppose dust needs to settle on the ppa :)

from indi.

kecsap avatar kecsap commented on August 15, 2024

I am almost afraid to report this ...

Don't be afraid, I still learn how to modify best a very popular software like INDI. Sorry for any breakage what my GSoC activities result in the codebase.

Ok, the problem is two-fold here:

  • The CMakeLists.txt in 3rd-party plugins did not contain the fix from @TallFurryMan for _FORTIFY_SOURCE.
  • I think I was too strict to turn all compiler warnings to errors by default. It can create some hassle for people working on non-Debian systems and it is clear that we can't run tests on every system.

I created a new PR to solve all these problems:

  1. Compiler warnings will not be turned to errors by default. Although I still would like to enforce it on Travis CI.
  2. I added @TallFurryMan's fix to the 3rd-party's CMakeLists.txt.

PR: #266

from indi.

kecsap avatar kecsap commented on August 15, 2024

Ok, my PR merged. Please try the latest master again.

from indi.

justanenduser avatar justanenduser commented on August 15, 2024

from indi.

kecsap avatar kecsap commented on August 15, 2024

@justanenduser: You can bless my day if you close this issue. :-D

from indi.

justanenduser avatar justanenduser commented on August 15, 2024

You shall receive. :-)

Thanks,
-Gary-

from indi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.