Attempting to choose non-utf-8 text file on text preview widget on Windows crashes about nodezator HOT 9 CLOSED

Please, go to the location where nodezator is installed and inside the "nodezator" folder there should be a "logs" folder with the logs from your session.

from nodezator.

Please, also try, to update your installation using pip install --upgrade nodezator (in my machine it only works when called 02 times), or download from github again, if you didn't install). Then, try the same steps you made again. This time a dialog should appear instead of the app crashing.

If you locate the logs upload them here so I can take a look, please.

from nodezator.

Updating to 1.0.5 allows selecting a filepath on Windows. Thanks!

from nodezator.

Oh, really? That's great news! May I close this issue then?

from nodezator.

Actually, I'm getting an error:

which then says:

So I guess I need a UTF8 text file --- perhaps that requirement should be made a part of the node?

from nodezator.

I believe I get the problem now. The node is fine, it even has a field where you can specify the encoding. The problem is that the widget has to load the file in order to show you a preview and it does so using a 'utf-8' encoding. To solve this I guess I'll have to either analyse the file and then choose the appropriate encoding used to load it for the preview or just keep using the utf-8 encoding by use a more lenient loading method that ignore unicode errors (the pathlib.Path.read_text() method has a parameter to allow this if I'm not mistaken).

I'll look into this right away and upload a new patch.

from nodezator.

Ok, please, try updating your Nodezator version to 1.0.6 now, and repeat the steps that led to your original problem. See if no errors are raised anymore.

Also, if the text is previewed in the widget, click the preview and see if the file is displayed in the text viewer inside the app, some characters should probably not render well, but apart from that it should be fine.

from nodezator.

That worked!

I'd suggest making the encoding entry a pop-up, and having the program determine the valid options and only afford them.

from nodezator.

Yes, setting the errors parameter to ignore encoding errors was just a stopgap measure to prevent the app to crash on the users and allow them to keep working. I'll think of a better solution. and put this problem in my to-do list.

Since I believe the problem (crashing) was solved, if you don't mind I'll be closing this issue.

from nodezator.