Code Monkey home page Code Monkey logo

Comments (4)

konstantinstadler avatar konstantinstadler commented on August 11, 2024

Thanks for using country converter and giving feedback!

For the US and Korea I can not reproduce but I see the problem with UK:

In [1]: import country_converter as coco                                                                                                              

In [2]: coco.convert("US", to="short")                                                                                                                
Out[2]: 'United States'

In [3]: coco.convert("USA", to="short")                                                                                                               
Out[3]: 'United States'

In [4]: coco.convert("UK", to="short")                                                                                                                
WARNING:root:UK not found in ISO2
Out[4]: 'not found'

In [5]: coco.convert("GB", to="short")                                                                                                                
Out[5]: 'United Kingdom'

In [6]: coco.convert("KR", to="short")                                                                                                                
Out[6]: 'South Korea'

In [7]: coco.convert("Ireland", to="ISO2")                                                                                                            
Out[7]: 'IE'

The problem with UK is, that GB is the official ISO 2 code and if the code sees two letters it assumes ISO2. This however works:

In [12]: coco.convert("UK", src="regex", to="short")                                                                                                  
Out[12]: 'United Kingdom'

Perhaps I would need to see some code/minimal examples to fully understand the other issues (make sure you updated to the latest version as well). Principally, I am happy to help but I am on paternity leave until September so there might be some delays in my answers.

Best
kst

from country_converter.

TheBugYouCantFix avatar TheBugYouCantFix commented on August 11, 2024

from country_converter.

konstantinstadler avatar konstantinstadler commented on August 11, 2024

Ok, this should be all fixed now in the current development version.

In [1]: import country_converter as coco                                                                                                                                                                             

In [2]: coco.convert('UK', src='regex')                                                                                                                                                                              
Out[2]: 'GBR'

In [3]: coco.convert('GB', src='regex')                                                                                                                                                                              
Out[3]: 'GBR'

In [4]: coco.convert('US', src='regex')                                                                                                                                                                              
Out[4]: 'USA'

In [5]: coco.convert('USA', src='regex')                                                                                                                                                                             
Out[5]: 'USA'

In [6]: coco.convert('Ireland', src='regex')                                                                                                                                                                         
Out[6]: 'IRL'

In [7]: coco.convert('Republic of Ireland', src='regex')                                                                                                                                                             
Out[7]: 'IRL'

In [8]: coco.convert('Macau', src='regex')                                                                                                                                                                           
Out[8]: 'MAC'

This is not on pypi yet, you can install the latest release candidate with

pip install git+https://github.com/konstantinstadler/country_converter --upgrade

Let me know if there any remaining issues

from country_converter.

TheBugYouCantFix avatar TheBugYouCantFix commented on August 11, 2024

from country_converter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.