Don't leave debugging calls in your source code about erlang_guidelines HOT 5 CLOSED

I agree and I always do:

git diff | grep lager

Just in case though, I feel logging more than strictly necessary as long as you do it with the proper severity level could be useful to debug issues that arise but you didn't expect. I would assume this rule means no lager:notice("reached step 3 of the algorithm, it works!!) but keeping reasonable logs is allowed. If that's the case, the rule could use some rewording, if not then I am not fully on board.

from erlang_guidelines.

👍

from erlang_guidelines.

+1

from erlang_guidelines.

If elvis had to detect these things I guess it could only figure out the io:format and ct:pal for sure. But error:logger and lager:xxx calls might be just fine in most projects, right?

from erlang_guidelines.

@jfacorro yeah… I opened inaka/elvis#270 for that and I specifically wrote as far as possible there for that. But this is a rule for humans, here ;)

from erlang_guidelines.