Complain about preprocessor macro use. about elvis_core HOT 12 CLOSED

I'd like to give this a go, if still deemed valuable. I believe the proper syntax would be:

{elvis_style, no_macros, #{allowed_macros => ["EXCEPTION_1", "EXCEPTION_2"], ignore => [module_1, module_2]}}

In any case, it will surely bring up a lot of results in any given project, so either the ignore list will become huge (and every time you add a macro you have to allow it) or consumers will just disable the rule (unless you meant not having it enabled by default, which is also valid).

from elvis_core.

I would say "Go ahead, my brave fellow!!", but don't include the rule in the erl_files ruleset just yet.

Maybe… if people want to use this rule, but still have some macros… they can put the macros in an hrl file that's not checked with this rule… Not that I like that solution, just saying that it will exist 🙈

from elvis_core.

Oh, the rule will check for macro usage, not macro definition… 🤔 … In that case, my solution doesn't work. 🤷

from elvis_core.

Yeah, seems feasible. I'll preemptively assign it to me.

from elvis_core.

There's a chance this'll eventually use some of the code from #131, since the latter messes with macro identification (we will need the list of built-in macros somewhere, right?).

from elvis_core.

Like… here, you mean?

from elvis_core.

Like… here, you mean?

Yes. I'd like it to be available by code, but we can start with that 😄

from elvis_core.

Like this then… but exported 😢

from elvis_core.

Like this then… but exported 😢

That'd be sweet. Let me ask around.

from elvis_core.

For reference...

Something (undocumented) like this is also possible

1> {ok, Epp} = epp:open("**REDACTED**/rebar3_hex/src/rebar3_hex.erl", []).
{ok,<0.84.0>}
2> epp:macro_defs(Epp).                                                                      
[{{atom,'BASE_MODULE'},undefined},
 {{atom,'BASE_MODULE_STRING'},undefined},
 {{atom,'BEAM'},{none,[{atom,1,true}]}},
 {{atom,'FILE'},
  {none,[{string,1,
                 "**REDACTED**/rebar3_hex/src/rebar3_hex.erl"}]}},
 {{atom,'FUNCTION_ARITY'},undefined},
 {{atom,'FUNCTION_NAME'},undefined},
 {{atom,'LINE'},{none,[{integer,1,1}]}},
 {{atom,'MACHINE'},{none,[{atom,1,'BEAM'}]}},
 {{atom,'MODULE'},undefined},
 {{atom,'MODULE_STRING'},undefined},
 {{atom,'OTP_RELEASE'},{none,[{integer,1,21}]}}]

from elvis_core.

HA! That's super-hacky… I like it. It should go into katana-code

from elvis_core.

I've moved to implement this, thus the last change ("removed their assignment now").

from elvis_core.