Comments (4)
SantiagoTorres
commented on August 15, 2024
This sounds like a better, more idomatic way to do error handling. It also sounds it'd be super helpful to improve testing.
Is there a way to do this gradually?
from in-toto-golang.
shibumi
commented on August 15, 2024
@SantiagoTorres Yes, I just pushed 3 new error types in my latest in-toto-run commit. The error handling gets so much better with this.
We get basically from something like this:
expectedError := "Could not find a public key PEM block"
err = key.LoadRSAPublicKey("demo.layout.template")
if err == nil || !strings.Contains(err.Error(), expectedError) {
t.Errorf("LoadRSAPublicKey returned (%s), expected '%s' error", err,
expectedError)
}to:
err = key.LoadRSAPublicKey("demo.layout.template")
if !errors.Is(err, ErrNoPEMBlock) {
t.Errorf("LoadRSAPublicKey returned (%s), expected '%s' error", err,
ErrNoPEMBlock.Error())
}from in-toto-golang.
lukpueh
commented on August 15, 2024
Cross-referencing with #5.
from in-toto-golang.
sarthaksarthak9
commented on August 15, 2024
@shibumi is this issue still up ?
from in-toto-golang.
Related Issues (20)
- Add version/SHA to provevanceBuilder HOT 3
- Support older SLSA version and v1.0 HOT 8
- CycloneDX predicate is wrong HOT 1
- non unique dictionary key error HOT 9
- Support v1.0 SLSA provenance format
- in-toto-golang does not provide defaults for excluding artifacts HOT 7
- Inconsistent path match behaviour compared to python implementation HOT 4
- Option to substitute signing algorithm to a custom version HOT 3
- Verification using ED25519 keys for functionaries returns error HOT 9
- Typo in provenance structure HOT 1
- Revisit type assertions
- in-toto-golang record stop doesn't removes unfinished link. HOT 2
- Add OpenSSF Scorecards HOT 3
- Use in-toto/attestation Go bindings for Statement and SLSA provenance predicate layers
- ALLOW pattern doesn't work as expected on windows HOT 1
- Oversight in the SLAS v1 field `invocationID`? HOT 7
- Define intoto v1.0 statement type HOT 6
- Improve Scorecard score for in-toto-golang HOT 1
- CII OpenSSF best-practice badge HOT 1
- Source code missing for test/data/helloworld binary HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from in-toto-golang.