Comments (6)
@tir38 the issue is that "tir38:{}" is not a valid object/map in YAML. this can be fixed by adding a space after the colon, e.g. "tir38: {}"
pull-review 2.5.6 will error out on invalid config like this
from pull-review.
could you paste your .pull-review file and double check that every one of the reviewers is either a collaborator or part of a group with access to your repo?
from pull-review.
# pull-review config version (required)
version: 1
# minimum number of reviewers to assign and notify for a pull request
min_reviewers: 1
# maximum number of reviewers to assign and notify for a pull request
max_reviewers: 2
# if at least a minimum number of reviewers is not found, assign a minimum number of reviewers randomly
assign_min_reviewers_randomly: true
# require a user to be listed in the reviewers section in order to be assigned to a pull request
require_notification: true
# use review requests instead of assignees to assign reviewers to pull requests
use_review_requests: true
# list of users and their app-specific usernames
reviewers:
tir38:{}
It doesn't matter whether user is a "collaborator" or member of a "team":
from pull-review.
thanks @tir38 will try to replicate on a new repo
from pull-review.
i can replicate the issue @tir38, fix coming up
from pull-review.
Ewww gross. Thanks for looking into this. If I run my script through a YAML formatter I see what you mean:
no space maps to :
reviewers: "tir38:{}"
with the space it maps to:
reviewers:
tir38:{}
from pull-review.
Related Issues (20)
- Add a temporary lock on a review request for the same PR
- Group blame by commit/timestamp
- Optionally show stats about the PR in chat message (files/LOC changed) HOT 1
- Allow purely random assignment HOT 1
- Enable excluding initial and subsequent reviewers for a PR when retrying review
- Rank fallback reviewers by the count of files that the fallbacks apply to
- Oluchifx HOT 1
- Display number of lines when requesting reviews via hubot HOT 1
- Support for opt-in reviewer direct messages on slack
- Request reviews instead of assigning to PR HOT 1
- Add caching for .pull-review and git blame
- Add support for draft pull requests
- Clarify in docs what GitHub permissions are necessary on a repo-level
- Improve "minimum reviewers" error message
- Add tolerance for spelling mistakes in "review" and "again"
- Add exponential back-off when fetching pull request
- Add a "ping" mode for "review again" where re-assignment occurs after a number of retries
- parseGithubURL doesn't account for Enterprise Github HOT 1
- Gitlab support HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pull-review.