Code Monkey home page Code Monkey logo

Comments (6)

imsky avatar imsky commented on June 21, 2024 1

@tir38 the issue is that "tir38:{}" is not a valid object/map in YAML. this can be fixed by adding a space after the colon, e.g. "tir38: {}"

pull-review 2.5.6 will error out on invalid config like this

from pull-review.

imsky avatar imsky commented on June 21, 2024

could you paste your .pull-review file and double check that every one of the reviewers is either a collaborator or part of a group with access to your repo?

from pull-review.

tir38 avatar tir38 commented on June 21, 2024
# pull-review config version (required)
version: 1

# minimum number of reviewers to assign and notify for a pull request
min_reviewers: 1

# maximum number of reviewers to assign and notify for a pull request
max_reviewers: 2

# if at least a minimum number of reviewers is not found, assign a minimum number of reviewers randomly
assign_min_reviewers_randomly: true

# require a user to be listed in the reviewers section in order to be assigned to a pull request
require_notification: true

# use review requests instead of assignees to assign reviewers to pull requests
use_review_requests: true

# list of users and their app-specific usernames
reviewers:
  tir38:{}

It doesn't matter whether user is a "collaborator" or member of a "team":

screen shot 2019-02-01 at 5 00 03 pm

from pull-review.

imsky avatar imsky commented on June 21, 2024

thanks @tir38 will try to replicate on a new repo

from pull-review.

imsky avatar imsky commented on June 21, 2024

i can replicate the issue @tir38, fix coming up

from pull-review.

tir38 avatar tir38 commented on June 21, 2024

Ewww gross. Thanks for looking into this. If I run my script through a YAML formatter I see what you mean:

no space maps to :

reviewers: "tir38:{}"

with the space it maps to:

reviewers: 
  tir38:{}

from pull-review.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.