Comments (8)
Hi Patrick! Thank you for bringing this to my notice. I am currently working on PyPulseq 1.3.1 to match Pulseq 1.3.1.
I understand your concern and urgency. If you have tested with 1e-8
and it works as expected for you, please make a PR to the dev branch. I will merge changes asap and get back to you.
from pypulseq.
I've merged the PR into the dev branch. You must be able to install the latest commit from the dev branch as follows: pip install git+https://github.com/imr-framework/pypulseq.git@dev
.
Let me know if it works! :)
from pypulseq.
Thanks for the fast response and fast merge. The compressed shapes in the seq-files created in python match the matlab version now! Great!
Is there any chance that this minor change makes it into a release 1.2.0post5 etc in the very near future?
I would love to list pypulseq (including the change) as an install requirement in the setup.py of our python package. Although listing git branches as requirement does work now (!), it is still kind of a work around and of course requires the user to have Git installed. To keep our project as simple and user friendly as possible, it would be amazing if we could avoid this Git requirement.
Thanks again!
from pypulseq.
I am on track to releasing PyPulseq 1.3.1 very soon. Hopefully in the next 7 days or sooner!
from pypulseq.
Sounds good! Just to be sure: will you definetely include this fix in the next release? Would be good to know if we can mention it in the publication.
from pypulseq.
Yes 100%!
from pypulseq.
Hi! I've just released the latest version. Please take a look and let me know if I can close this issue. :)
from pypulseq.
Hey!
The shape compression works perfect with the latest version. You can close the issue.
However, we found some other minor bugs/errors as I wrote in #36. Let me know how you prefer me to report/contribute.
from pypulseq.
Related Issues (20)
- np.int and np.float HOT 1
- AttributeError when calling calculate_kspace() in sequence.py HOT 2
- CI Tests HOT 1
- Cannot generate trapezoidal gradient only specifying amplitude and duration. HOT 1
- Arguments of make_block_pulse are highly confusing HOT 3
- make_trapezoid with just flat_area fails HOT 6
- Conda Package for Pypulseq HOT 5
- PyPulseq requires GPU compute (cuPy) on Google Colab HOT 2
- KeyError When Reading .seq File generated from MATLAB pulseq 1.4.0 in pypulseq 1.4.0 HOT 5
- Pypulseq ignores BlockDurationRaster Definition in file
- Compatibility with Pulseq 1.3.1 broken HOT 1
- Feature: Sequence `install`
- Sigpy pulses can not be added to sequence HOT 1
- add_blocks interpolation issue HOT 2
- "Identical" shapes not found in event_lib HOT 4
- Numpy float error when importing pypulseq HOT 1
- Change default branch back to main HOT 1
- Incompatibility of sigpy dependency with scipy 1.14.0 and numpy 2.0 HOT 1
- block duration rounding assertion test HOT 1
- Rounding error in add_gradients leads to incorrect gradient waveforms HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pypulseq.