Missmatch between compress_shape function in Python and MATLAB about pypulseq HOT 8 CLOSED

Hi Patrick! Thank you for bringing this to my notice. I am currently working on PyPulseq 1.3.1 to match Pulseq 1.3.1.
I understand your concern and urgency. If you have tested with 1e-8 and it works as expected for you, please make a PR to the dev branch. I will merge changes asap and get back to you.

from pypulseq.

I've merged the PR into the dev branch. You must be able to install the latest commit from the dev branch as follows: pip install git+https://github.com/imr-framework/pypulseq.git@dev.

Let me know if it works! :)

from pypulseq.

Thanks for the fast response and fast merge. The compressed shapes in the seq-files created in python match the matlab version now! Great!

Is there any chance that this minor change makes it into a release 1.2.0post5 etc in the very near future?

I would love to list pypulseq (including the change) as an install requirement in the setup.py of our python package. Although listing git branches as requirement does work now (!), it is still kind of a work around and of course requires the user to have Git installed. To keep our project as simple and user friendly as possible, it would be amazing if we could avoid this Git requirement.

Thanks again!

from pypulseq.

I am on track to releasing PyPulseq 1.3.1 very soon. Hopefully in the next 7 days or sooner!

from pypulseq.

Sounds good! Just to be sure: will you definetely include this fix in the next release? Would be good to know if we can mention it in the publication.

from pypulseq.

Yes 100%!

from pypulseq.

Hi! I've just released the latest version. Please take a look and let me know if I can close this issue. :)

from pypulseq.

Hey!
The shape compression works perfect with the latest version. You can close the issue.
However, we found some other minor bugs/errors as I wrote in #36. Let me know how you prefer me to report/contribute.

from pypulseq.