Comments (3)
@grlee77 Thank you for your inputs. The 1:1 mapping was purely intended to provide familiarity to users jumping from Matlab. What do you think about rf
and grad
sub-packages instead of modules? I can imagine that a single rf.py
module would be not so pretty to look at.
from pypulseq.
I am not saying you have to make any change here, it was just a suggestion. In your case, it may be beneficial to continue to mirror the structure of the Matlab code if you anticipate most users are migrating from Matlab and are more familiar with that structure. In that case, just go ahead and close this issue.
I can imagine that a single rf.py module would be not so pretty to look at.
I don't really agree. For Python projects, it is very common to group several related functions together in a single file. As a concrete 3rd party example, see the imports at the top of init.py for the filters submodule of scikit-image. Here there are several files within the filters
folder, some of which have several functions internally, but they are grouped in a logical manner (e.g. edges vs. thresholding). To me, that seems better than if every individual function in that module were stored in its own file.
from pypulseq.
Thanks for sharing the scikit-image example, I suppose we will stick to the MATLAB convention to ensure familiarity. Once again, thanks for your insights, I learnt something new.
from pypulseq.
Related Issues (20)
- np.int and np.float HOT 1
- AttributeError when calling calculate_kspace() in sequence.py HOT 2
- CI Tests HOT 1
- Cannot generate trapezoidal gradient only specifying amplitude and duration. HOT 1
- Arguments of make_block_pulse are highly confusing HOT 3
- make_trapezoid with just flat_area fails HOT 6
- Conda Package for Pypulseq HOT 5
- PyPulseq requires GPU compute (cuPy) on Google Colab HOT 2
- KeyError When Reading .seq File generated from MATLAB pulseq 1.4.0 in pypulseq 1.4.0 HOT 5
- Pypulseq ignores BlockDurationRaster Definition in file
- Compatibility with Pulseq 1.3.1 broken HOT 1
- Feature: Sequence `install`
- Sigpy pulses can not be added to sequence HOT 1
- add_blocks interpolation issue HOT 2
- "Identical" shapes not found in event_lib HOT 4
- Numpy float error when importing pypulseq HOT 1
- Change default branch back to main HOT 1
- Incompatibility of sigpy dependency with scipy 1.14.0 and numpy 2.0 HOT 1
- block duration rounding assertion test HOT 1
- Rounding error in add_gradients leads to incorrect gradient waveforms HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pypulseq.