electric-pair-skip-self about lua-mode HOT 4 CLOSED

Hi and thanks for the report. I'll see to it.

It would help, though, to have complete sequence of actions from startup (emacs -q -l lua-mode.el) to the point of failure.

from lua-mode.

Hi immerrr. Thanks for response.
How to reproduce:

1. emacs -q -l lua-mode.el
2. C-x b foo
3. M-x lua-mode
4. M-x electric-pair-mode
5. C-h v electic-pair-skip-self ; should be true by default, if no, set it
6. Type ( ; closing paren is automatically inserted
7. Type ) ; should move forward skipping autoinserted paren, but instead it adds another one.

Try 4-7 in c-mode or ruby-mode to see how it works.
Thanks.

from lua-mode.

Hi, it looks like the problem is that lua-electric-match calls insert-char directly, but electric-pair-mode hooks self-insert-command. Seems to be fixed by

diff --git a/lua-mode.el b/lua-mode.el
index 08862ec..934d31b 100644
--- a/lua-mode.el
+++ b/lua-mode.el
@@ -710,7 +710,7 @@ Groups 6-9 can be used in any of argument regexps."
 (defun lua-electric-match (arg)
   "Insert character and adjust indentation."
   (interactive "P")
-  (insert-char last-command-event (prefix-numeric-value arg))
+  (self-insert-command (prefix-numeric-value arg))
   (if lua-electric-flag
       (lua-indent-line))
   (blink-matching-open))

Although I guess lua-electric-match would be redundant altogether if eletric-pair-mode and electric-indent-mode are both enabled.

from lua-mode.

Should work now. Special thanks go to @npostavs for providing a solution.

from lua-mode.