Comments (26)
Potentially related: gatsbyjs/gatsby#33199 (comment)
from gatsby.
Hey @finematterdave, thanks for the offer. At this stage I don't exactly know what is going here - will take a look at this next week and give an update then.
from gatsby.
Hey @finematterdave thanks for following up! Unfortunately this one slipped through the cracks - I'll make sure I get onto this next week (hopefully Tuesday)
from gatsby.
@finematterdave just wanted to follow up here that I'm still investigating this. I hope to have another update for you in the coming days
from gatsby.
Hi @finematterdave, I'm still investigating this. At least this time I've managed to reproduce the issue! Will let you know how I go
from gatsby.
Hey @frederickfogerty, I replied to your comment in the Gatsby discussion. Let me know if you have any questions. 👍
from gatsby.
Does seem like it's very similar... @frederickfogerty happy to PR something if you've got an approach that'd make sense for this plugin
from gatsby.
Hey @frederickfogerty , sorry to bug you, did you get a chance to look at this?
from gatsby.
Hi @finematterdave, I looked into this today and I can't seem to reproduce your issue:
Dependencies
"dependencies": {
"@imgix/gatsby": "1.7.0",
"gatsby": "^4.3.0",
"gatsby-plugin-image": "^2.4.0",
"react": "^17.0.1",
"react-dom": "^17.0.1"
}
If this issue is still persisting for you, could post more of your gatsby-config.js
, the specific commands use to trigger the issue, your dependency versions, and if possible an example repo which is showing the issue?
from gatsby.
Hey @frederickfogerty , apologies, I shouldn't have said "build" in my original issue, looking closer this seems to only happen when using the gatsby develop
or gatsby serve
commands when we try and run some automated tests in the CI. Let me know if it happens for you with develop instead and I'll work on a basic repo to share as well
As @angeloashmore mentioned it seems similar to gatsbyjs/gatsby#33199 (comment)
from gatsby.
Actually getting a test repo up and running is painful due to #155 not being released yet, once that is I'll set something up with the quick start gatsby repo (all their stuff is on the newer versions now, so gets into some dependency issues)
from gatsby.
Unfortunately, I also couldn't repro it with the develop
command.
I released #155 in 1.7.4
just now - let me know if that helps you.
from gatsby.
https://github.com/finematterdave/example-imgix-issue is a broken example, clone, run npm install
then npm run build
, let me know if it's also broken for you... hope so!
from gatsby.
No problem, thanks @frederickfogerty, let me know if I can help at all
from gatsby.
Turns out @angeloashmore was totally correct, it is related to gatsbyjs/gatsby#33199 (comment). This took a long day of debugging and searching to find out what was going wrong. I'm going to wait for Angelo to update me about any fixes he made, but at this I don't have an immediate fix.
from gatsby.
Thanks @angeloashmore - replied over there too
from gatsby.
Hey @frederickfogerty , any thoughts on an approach here?
from gatsby.
Hi @finematterdave. We are going to rework the configuration of this plugin to not use a function option, and instead use a string option for the getURL
config option. I have been slammed both on vacation a lot recently and lots of other high priority work has come up so I haven't been able to get to this, but if you feel like opening a PR for this change, that would be welcome. Otherwise, I hope to be able to get to this next week or the week after.
from gatsby.
No worries @frederickfogerty , I probably won't get time to get to it before you do, but the approach sounds sensible! Hope you had a nice break 🏝
from gatsby.
Hi @finematterdave, I just released this onto our prerelease channel - would you be able to help us test this out? 🙌 You can install the prelease channel with yarn add @imgix/gatsby@next
from gatsby.
🎉 This issue has been resolved in version 1.7.6-rc.1 🎉
The release is available on:
Your semantic-release bot 📦🚀
from gatsby.
Hey @frederickfogerty , works great for me, readme instructions were nice and clear too, good work! 🎉
from gatsby.
Hey @finematterdave just wanted to follow up here and see how this was going for you and if you had any issues? If it's been smooth, then we'll promote this to the stable channel
from gatsby.
Yep all good for us, been working fine and haven't found any strange issues
from gatsby.
from gatsby.
🎉 This issue has been resolved in version 1.7.6 🎉
The release is available on:
Your semantic-release bot 📦🚀
from gatsby.
Related Issues (20)
- Use multiple sources within the same project HOT 3
- Building schema failed: Type `<type name>` declared in `createTypes` looks like a node, but doesn't implement a `Node` interface HOT 10
- Unable to provide the right src to ImgixGatsbyImage and fetching images: error 403. HOT 6
- getGatsbyImageData() returns larger images than needed in scrSet HOT 1
- feat: more debugging features HOT 4
- AVIF format not showing HOT 4
- Type Definition for "TRACED_SVG" Missing HOT 1
- feat: gracefully handle empty image URL fields HOT 5
- Js-core being exported in production as 57.7kb HOT 3
- Version 2.0.1 broken NPM package, missing dist/ folder HOT 2
- Is it possible to sign URLs when using the `getGatsbyImageData` hook? HOT 3
- feat: support for images within markdown HOT 2
- deprecated [email protected] dependency HOT 1
- `disableIxlibParam` doesn't work HOT 4
- Gatsby V5 support - graphql dependency HOT 3
- fix: Invalid plugin options for "@imgix/gatsby" - "domain" is required HOT 5
- fix: no support for `gatsby-plugin-image@3` so no `gatsby@5` support HOT 6
- ERROR @imgix/gatsby not working at all at build proccess HOT 3
- Is it possible to use customized GraphQL fields?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gatsby.