Make pillow and numpy optional about dicomweb-client HOT 5 CLOSED

Good point. I like the idea of declaring them "extra" dependencies.

from dicomweb-client.

I have thought about this a bit more and am considering deprecating the functionality for decoding images client side altogether. This is beyond the scope of this library and was probably not a good idea to take this on in the first place. The client could instead retrieve an image rendered from the server using the WADO-RS Retrieve Rendered Transaction.

from dicomweb-client.

@dimrozakis sorry for the slow turnaround. I have looked into the dependencies and think we could remove all dependencies but requests and pydicom (see e236023).

We would loose the ability to decompress and view images, but I think this should probably be handled outside of this library anyways. With hindsight, I should not have added this functionality to begin with.

What do you think?

I would like to add a few unit tests before releasing this, but would appreciate if you could already test it in your constrained environment.

from dicomweb-client.

Hi @hackermd

We would loose the ability to decompress and view images, but I think this should probably be handled outside of this library anyways.

I agree. And these features are technically only available in the CLI, any users of the library would have to handle them on their own even with the current implementation. Just as displaying DICOMs is presumably out of scope for this client, it makes sense that displaying JPEGs would be too. These features are also very easy to implement on the client side (of a library user) with just a few lines of code, so no great benefit by including it in. Overall I'd vote to deprecate these features & their dependencies.

I would like to add a few unit tests before releasing this, but would appreciate if you could already test it in your constrained environment.

I'm busy working on some other projects at the moment, but towards the end of the week I should be returning on this subject. I should also note that my usage of this project, as mentioned in the original post, is limited on the library (api.py::DICOMwebClient) and I haven't ever really used cli.py where all of the relevant changes are made in e236023, but I'll be pulling in your commit to try it out.

from dicomweb-client.

Dependencies have been removed since version 0.30

from dicomweb-client.