offering does not display in student search if published with no student group associations about ilios HOT 3 CLOSED

acknowledged.
the problem lies within the monster query that gets generated in Canned_Queries::getOfferingsForCalendar()

specifically, see this query fragment:
https://github.com/ilios/ilios/blob/rb2.3/web/application/models/canned_queries.php#L176

this should be a LEFT JOIN.

No idea why the LEFT keyword is only conditionally applied if multiple roles are given as input, this can't be right.
(Git blame/history does not reveal anything useful)

Another facet of this problem is that offerings without instructor/instructor-group will not be shown in the filtered educator view.

working on a fix for this as well.

from ilios.

@saschaben , please review the fix in the student- and educator-dashboard on ilios-dev.
for comparison purposes please use the ilios-dev/stefan sandbox - it's rigged up to the same database but still employs the old code.
thanks!

from ilios.

PASS.

Please close and commit.

from ilios.