Code Monkey home page Code Monkey logo

Comments (6)

jph00 avatar jph00 commented on May 31, 2024 2

I was always think about this, but it may be a breaking change, so I'm not 100% sure.

I suspect there are a lot more people that aren't able to use this (or need hacky workarounds) because of the inconsistency with 3.6, than there are people relying on the existing behavior (if any). So I think fixing it would be best.

Just my $0.02 :)

from typing_inspect.

ilevkivskyi avatar ilevkivskyi commented on May 31, 2024

Hm, this looks like a bug. I think for bare class objects get_origin() should always return the class object itself. Would you like to submit a PR?

from typing_inspect.

mitar avatar mitar commented on May 31, 2024

Not sure how to know if it is a bare class?

from typing_inspect.

septatrix avatar septatrix commented on May 31, 2024

The way it works since 3.7 is at least consistent with typing.get_origin() inside the stdlib which got introduced in 3.8

from typing_inspect.

mitar avatar mitar commented on May 31, 2024

Yea, it would be great if then get_origin from this package would work on 3.6 the same as it does on 3.7 and 3.8.

from typing_inspect.

ilevkivskyi avatar ilevkivskyi commented on May 31, 2024

Yea, it would be great if then get_origin from this package would work on 3.6 the same as it does on 3.7 and 3.8.

I was always think about this, but it may be a breaking change, so I'm not 100% sure.

from typing_inspect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.