tried to download the tutorials from command line using

I think this can be closed now, <a class="user-mention notranslate" data-hovercard-typ

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

download tutorials,about iiasa/message_ix

byersiiasa commented on May 29, 2024 1

fixed!

from message_ix.

gidden commented on May 29, 2024

I think this can be closed now, @byersiiasa can you confirm please?

from message_ix.

Jihoon commented on May 29, 2024

I also saw this. I am just ignoring it for now.

from message_ix.

byersiiasa commented on May 29, 2024

@gidden Just tried this again, still happening.
Error occurs regardless of using command prompt or anaconda prompt.

NB: Files downloaded correctly to the folder nonetheless. I will note on the installation instructions to ignore the issue for now.

from message_ix.

khaeru commented on May 29, 2024

This is probably because archive.close() is not called before shutil.rmtree(tmp) in do_dl():

message_ix/message_ix/cli.py

Lines 99 to 112 in 154c581

    
           archive = zipfile.ZipFile(dst) 
        
           logger().info('Unzipping {} to {}'.format(dst, tmp)) 
        
           archive.extractall(tmp) 
        
           if not os.path.exists(local_path): 
        
               os.makedirs(local_path) 
        
           cpfrom = '{}/message_ix-{}/{}'.format(tmp, branch or tag, repo_path) 
        
           cpto = '{}/{}'.format(local_path, repo_path) 
        
           logger().info('Copying {} to {}'.format(cpfrom, cpto)) 
        
           recursive_copy(cpfrom, cpto, overwrite=True) 
        
           shutil.rmtree(tmp)

From the Python docs:

You must call close() before exiting your program or essential records will not be written.

…makes it seem like the file handle for master.zip will not be released until that call is made. ZipFile.open() can also be used as a context manager, which will do this automatically.

from message_ix.

gidden commented on May 29, 2024

Yes this seems a correct diagnosis for me. Sadly it's not consistent across oses. To close this, we should do the fix and add a test.

…

On Tue, Dec 11, 2018, 3:53 AM Paul Natsuo Kishimoto < ***@***.*** wrote: This is probably because archive.close() is not called before shutil.rmtree(tmp) in message_ix.cli.do_dl(). From the Python docs <https://docs.python.org/3/library/zipfile.html#zipfile.ZipFile.close>: You must call close() before exiting your program or essential records will not be written. …makes it seem like the file handle for master.zip will not be released until that call is made. ZipFile.open() can also be used as a context manager <https://docs.python.org/3/library/zipfile.html#zipfile.ZipFile.open>, which will do this automatically. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#34 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABVAEamCrdBzSNRlW50hriPKfmH9m6ATks5u33KQgaJpZM4UcnYI> .

from message_ix.

khaeru commented on May 29, 2024

@byersiiasa I believe I fixed this via #256; the .close() call is now included:

message_ix/message_ix/cli.py

Lines 101 to 102 in f1a43f0

    
           # Close *zipfile* so it can be deleted with *td* 
        
           archive.close()

Can you please test when you've a spare moment, and confirm by closing this issue?

from message_ix.

download tutorials about message_ix HOT 7 CLOSED

Comments (7)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	archive = zipfile.ZipFile(dst)
	logger().info('Unzipping {} to {}'.format(dst, tmp))
	archive.extractall(tmp)

	if not os.path.exists(local_path):
	os.makedirs(local_path)

	cpfrom = '{}/message_ix-{}/{}'.format(tmp, branch or tag, repo_path)
	cpto = '{}/{}'.format(local_path, repo_path)
	logger().info('Copying {} to {}'.format(cpfrom, cpto))
	recursive_copy(cpfrom, cpto, overwrite=True)

	shutil.rmtree(tmp)

	# Close zipfile so it can be deleted with td
	archive.close()