devtools::buildreadme reverts changes about ascotracer HOT 14 CLOSED

related to some comments made in #140

from ascotracer.

This should be fixed in 486209c

Can you check that the readme.Rmd reads correctly @IhsanKhaliq so the readme.md is rendered correctly from it

from ascotracer.

It keeps on reverting for me too. Is it because of two readme files? I deleted one but then I am getting an error. Currently, these are missing. I add them but they keep on reverting

from ascotracer.

For one thing, the README.Rmd doesn't knit properly at all when I try to knit it in RStudio. It errors on Line 93 with a message about an unused argument, primary_incoulum_intensity = 100.

from ascotracer.

whoops, I had an old version installed on my personal laptop

from ascotracer.

Seems to work fine for me? I just pushed changes after trying devtools::build_readme()

from ascotracer.

This seems to be working as Adam mentioned above

from ascotracer.

@IhsanKhaliq I noticed the last couple of commits you have changed the regular markdown file README.md .
Please check and change the The R markdown file README.Rmd.
The README.Rmd writes over the README.md file when the readme is built with devtools::build_readme()

Also make sure you are on the master branch as this is the most recent stable version.

from ascotracer.

When I run devtools::build_readme() it still makes changes to README.md.
Can you please check again @IhsanKhaliq

from ascotracer.

I just created pull request as Adam made changes to dev. You can merge that pull request

from ascotracer.

There are no conflicts

from ascotracer.

It works on main as per 6bd6fd2. It updates the values though

from ascotracer.

If you don't want the values to change, you need to use set.Seed().

from ascotracer.

Ahhh that's happening because seed number hasn't been set. That's fine then. I think this issue can be closed

from ascotracer.