Code Monkey home page Code Monkey logo

Comments (2)

JohnMoehrke avatar JohnMoehrke commented on August 22, 2024

Lynn, I don't understand this point, can you help me understand what you are pointing out?

ok... a logical AND condition written in logical OR format... the contents of these 2 specifications for the identifier parameter are a bit duplicative and also confusing.

I don't think there is a conflict or overlap. What might not be clear enough is that in FHIR repeating a parameter is a logical AND, one parameter with multiple values is OR.

AND -- ?identifier=urn:oid:1.2.3.4|145&identifier=urn:oid:2.16.840.1.113883.4.1|123456789

OR -- &identifier=urn:oid:1.2.3|,urn:oid:4.5.6|

note in the first one there are two "identifier=" separated by "&"; where in the second there is just one "Identifier=" with multiple values separated by ","

This concept of AND and OR was not understood well at the beginning of PDQm writing, where it should be better understood. We might not need to include so much text about this now days, relying more on the FHIR specification.
https://www.hl7.org/fhir/search.html#combining

I could also see good reason to just add clarification to the text we have. Specifically 2:3.78.4.1.2.4 Populating Which Domains are Returned
The first example should be better explained as asking for either 1.2.3 or 3.4.5;
The second example is asking for both a match on SMITH and also a identifier of 1.2.3.4.5

I am not against removing this section, as all of the parameters are affecting the output. I suspect this section exists because there was a similar section in PDQ.

from iti.pdqm.

lynnfel avatar lynnfel commented on August 22, 2024

Your recommendation for improving this is better than mine. Specifically (copied from your comment above):

This concept of AND and OR was not understood well at the beginning of PDQm writing, where it should be better understood. We might not need to include so much text about this now days, relying more on the FHIR specification.
https://www.hl7.org/fhir/search.html#combining

I could also see good reason to just add clarification to the text we have. Specifically 2:3.78.4.1.2.4 Populating Which Domains are Returned
The first example should be better explained as asking for either 1.2.3 or 3.4.5;
The second example is asking for both a match on SMITH and also a identifier of 1.2.3.4.5

from iti.pdqm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.