Comments (5)
@mpavlinov check out commit 95f7774 where I updated igniteui-angular.js
. I believe I fixed the bug that was stopping the directive from creating event subscriptions with the correct name.
I went through each of the samples and it seems to be okay, but I want you guys to give it a look before we merge it in.
from igniteui-angularjs.
I was aware of the grid feature events "problem". It was not actually a problem, but a specific case, because they are implemented as a nested jQuery UI widgets, thus before your fix in order to attach to the correct event you need to type the feature name as part of the event attribute name like this: event-paging-page-index-changed
. Your fix seems to resolve this issue. I made a small code refactoring in order to make sure that this is related only to the grid features.
For the paging problem I had to do another fix, because changing of the grid data source should trigger re-binding of the grid.
You can merge these changes back to the master branch.
from igniteui-angularjs.
Makes sense regarding the event names. Will the change I am suggesting here create any potential for event names to collide?
from igniteui-angularjs.
I don't see any problem with your changes.
from igniteui-angularjs.
Merged: 20cf7b9
from igniteui-angularjs.
Related Issues (20)
- igTree performance HOT 1
- exitEditMode after rebinding causes igGrid data to revert to old data HOT 4
- Angular JS Data Chart
- Error when setting datasource of combo editor provider of igGrid HOT 5
- Samples are broken
- igLayoutManager sample is not propertly working
- Error: cannot call methods on igGrid prior to initialization; attempted to call method 'destroy' HOT 1
- igTileManager sample is not loading correctly HOT 1
- Create igniteui-angularJS quickstart application HOT 1
- Help please HOT 2
- igCombo: setter method for the "mode" option HOT 1
- Update the npm package to match the updated repository name
- Can't type spaces (with space bar) in iggrid filter HOT 5
- Combo appends text after Shift-tabbed action
- Samples are broken on github.io HOT 1
- The igCombo directive misses a model.$isEmpty implementation
- Project build is failing
- Migrate protractor test to karma or enable them in github actions
- igCheckboxEditor does not update its model when ngModel is specified
- [igMap] Github pages sample is not shown HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from igniteui-angularjs.