Code Monkey home page Code Monkey logo

Comments (5)

craigshoemaker avatar craigshoemaker commented on June 14, 2024

@mpavlinov check out commit 95f7774 where I updated igniteui-angular.js. I believe I fixed the bug that was stopping the directive from creating event subscriptions with the correct name.

I went through each of the samples and it seems to be okay, but I want you guys to give it a look before we merge it in.

from igniteui-angularjs.

mpavlinov avatar mpavlinov commented on June 14, 2024

I was aware of the grid feature events "problem". It was not actually a problem, but a specific case, because they are implemented as a nested jQuery UI widgets, thus before your fix in order to attach to the correct event you need to type the feature name as part of the event attribute name like this: event-paging-page-index-changed. Your fix seems to resolve this issue. I made a small code refactoring in order to make sure that this is related only to the grid features.

For the paging problem I had to do another fix, because changing of the grid data source should trigger re-binding of the grid.

You can merge these changes back to the master branch.

from igniteui-angularjs.

craigshoemaker avatar craigshoemaker commented on June 14, 2024

Makes sense regarding the event names. Will the change I am suggesting here create any potential for event names to collide?

from igniteui-angularjs.

mpavlinov avatar mpavlinov commented on June 14, 2024

I don't see any problem with your changes.

from igniteui-angularjs.

craigshoemaker avatar craigshoemaker commented on June 14, 2024

Merged: 20cf7b9

from igniteui-angularjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.