Code Monkey home page Code Monkey logo

Comments (7)

ChristianFeldmann avatar ChristianFeldmann commented on June 26, 2024 1

I was able to add new corrected tags to the released versions.

from yuview.

ChristianFeldmann avatar ChristianFeldmann commented on June 26, 2024

Hi! Yep the .1 version you mentioned was because I just added a tiny bugfix. Or I did something tiny wrong in the release. I can't even remember. What would you recommend? Maybe do you have a link to a common scheme that is used most commonly? For me it does not matter. Its just a counter up.

from yuview.

frankplow avatar frankplow commented on June 26, 2024

Hi, I think the easiest is just to remove the dots on v.2.12 and v.2.13 as the majority seem to omit them. Mixing three or two levels to the version hierarchy is fine, it's more just the formatting. Thanks for your quick response!

from yuview.

ChristianFeldmann avatar ChristianFeldmann commented on June 26, 2024

Ah yes that is quite inconsistent. There should not be a dot and it should be v2.13. I agree. I think I can just rename them. There should not be an issue. May I ask what automated tool you are trying out there?

from yuview.

frankplow avatar frankplow commented on June 26, 2024

@ChristianFeldmann I'm using Homebrew. In particular, the reason I noticed this is that Homebrew has a feature called livecheck which searches the releases page to detect new releases and flag when the package is out-of-date. It does this by extracting the version number with a regex, which is usually just the version number itself and no leading v or whatever. The different naming then means that the package maintainer potentially has to manually update the URL each time, they can't just do, for example, https://github.com/IENT/YUView/releases/download/v#{version}/YUView-Mac.zip

Thanks for getting this fixed so quickly!

from yuview.

ChristianFeldmann avatar ChristianFeldmann commented on June 26, 2024

But for the regex you can also have it work with and without a dot: (.)?. But I will not try to make the same mistake again :)

from yuview.

frankplow avatar frankplow commented on June 26, 2024

The regex does extract the version number correctly, i.e. it gets 2.13 for v.2.13 and 2.13 for v2.13, it's putting this version number back into the URL for the download link that causes the issue. It would be fine if the version number had a leading ., but I don't think Homebrew likes this as it compares version numbers.

from yuview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.