Code Monkey home page Code Monkey logo

Comments (7)

brockallen avatar brockallen commented on July 23, 2024

Think about cookie or DB for persisting request message to support POST requests to authorize endpoint.

from identityserver3.

brockallen avatar brockallen commented on July 23, 2024

I'm wondering if the authorize endpoint should issue the cookie and not pass a protected query string. Seems a little much the way we did it. shrug

from identityserver3.

leastprivilege avatar leastprivilege commented on July 23, 2024

We don't need the protected query string. But issuing the cookie is def not the job ob the authZ endpoint.

from identityserver3.

brockallen avatar brockallen commented on July 23, 2024

It doesn't have to specifically be the authZ endpoint, but the action result or whatever. I'm just talking out loud -- the protected query string feel a little much given that these two are in the same middleware.

from identityserver3.

leastprivilege avatar leastprivilege commented on July 23, 2024

True. This comes from a discussion where the authZ endpoints wants to pass data to the login endoint in a "trusted way". As I said - we don't need it and it adds complexity right now. Wanna remove it?

from identityserver3.

brockallen avatar brockallen commented on July 23, 2024

Yea, I'll look at it Monday and think if there's a cleaner way. In short, I need a cookie in the all the authentication code anyway, so i was thinking why not use issue it and skip the query string. I also want a better API/abstraction for managing the cookie data. So that's all related.

from identityserver3.

leastprivilege avatar leastprivilege commented on July 23, 2024

We gonna keep the SignInMessage infrastructure, I switched everything to the new IDataProtector which by default is provided by the host.

from identityserver3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.