Comments (8)
Yes we can do that in the package. Note that these things are common in other R packages, so it may be difficult to avoid this in general in the Python layer when other packages are used.
@lilyclements Could you help to make these changes?
from cdms.products.
Happy to. Two questions:
- Should we look at the functions from R-Instat (or where should I report changes)? I don't want to create any issues down the line
- What should we do about
na.rm
? I assume we should just keep it
from cdms.products.
I'll also add in checkmate::
where appropriate while I'm at it.
from cdms.products.
I think just start with the Climsoft-like functions initially.
If we have an na.rm
parameter in any of our functions we can change this to na_rm
.
from cdms.products.
Great have done for the climsoft-like functions in #49
In addition, is it okay for the resulting data frame to have variables that contain a .
. This can occur in inventory_table
and inventory_plot
.
(And wwr_export
from the non-Climsoftesque functions).
R-Instat functions to edit:
climatic_missing
climdex
climdex_single_station
output_CDT
from cdms.products.
I think let's try to avoid that too, unless it's a requirement of the output in some way.
from cdms.products.
Great, Ive done that in PR #49
from cdms.products.
Fixed in PR #49
Thank you @lilyclements !
from cdms.products.
Related Issues (20)
- Creates extremes function
- Refer to `naflex` package on CRAN HOT 1
- Add an example dataset to the package
- Parameter names - consistency HOT 5
- Export CDT Dekadal data HOT 6
- Package name HOT 3
- Discussion on using "tidy evaluation" or not for column names HOT 2
- The signature of `export_geoclim_month` is inconsistent with Python
- Bugs in the inventory_plot function HOT 1
- Make tests accessible on installed package HOT 3
- Bug when using elements in the climatic_summary function HOT 2
- Add test for climatic_summary when there's no summaries provided
- Errors in prepare_geoclim function HOT 2
- Add test for climatic_summary that contains a `summaries_params` parameter HOT 3
- "element" not recognized in Input (file_path = paste0("CDT-", element, ".csv")
- Incorrect column names from export_geoclim_month.R
- R functions to write tests on HOT 4
- Parameters ignored in `export_geoclim_dekad()` and `export_geoclim_pentad()` HOT 1
- Invalid tests in `test-histogram_plot.R`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cdms.products.