Code Monkey home page Code Monkey logo

Comments (8)

dannyparsons avatar dannyparsons commented on June 20, 2024 1

Yes we can do that in the package. Note that these things are common in other R packages, so it may be difficult to avoid this in general in the Python layer when other packages are used.

@lilyclements Could you help to make these changes?

from cdms.products.

lilyclements avatar lilyclements commented on June 20, 2024

Happy to. Two questions:

  1. Should we look at the functions from R-Instat (or where should I report changes)? I don't want to create any issues down the line
  2. What should we do about na.rm? I assume we should just keep it

from cdms.products.

lilyclements avatar lilyclements commented on June 20, 2024

I'll also add in checkmate:: where appropriate while I'm at it.

from cdms.products.

dannyparsons avatar dannyparsons commented on June 20, 2024

I think just start with the Climsoft-like functions initially.

If we have an na.rm parameter in any of our functions we can change this to na_rm.

from cdms.products.

lilyclements avatar lilyclements commented on June 20, 2024

Great have done for the climsoft-like functions in #49

In addition, is it okay for the resulting data frame to have variables that contain a .. This can occur in inventory_table and inventory_plot.
(And wwr_export from the non-Climsoftesque functions).

R-Instat functions to edit:
climatic_missing
climdex
climdex_single_station
output_CDT

from cdms.products.

dannyparsons avatar dannyparsons commented on June 20, 2024

I think let's try to avoid that too, unless it's a requirement of the output in some way.

from cdms.products.

lilyclements avatar lilyclements commented on June 20, 2024

Great, Ive done that in PR #49

from cdms.products.

lloyddewit avatar lloyddewit commented on June 20, 2024

Fixed in PR #49
Thank you @lilyclements !

from cdms.products.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.