Code Monkey home page Code Monkey logo

Comments (4)

chris-prener avatar chris-prener commented on June 11, 2024 1

makes sense to me @idblr!

from ndi.

idblr avatar idblr commented on June 11, 2024

@chris-prener, I agree the rounding should be optional. Rounding the raw census data was implemented in the initial releases to match the output of the data provided by the NHLBI ADOPT Core Measures, see Socioeconomic Deprivation to replicate their approach with the powell_wiley() function.

I believe not rounding in future releases is the better approach; users can round after the calculation. Or would you prefer an additional argument?

from ndi.

chris-prener avatar chris-prener commented on June 11, 2024

Especially if you're replicating prior work, it makes sense to provide something that gets you as close as possible to the original estimates. I might suggest an argument with a logical scalar - something like round_output where TRUE allows you to match prior work and FALSE returns data without rounding?

from ndi.

idblr avatar idblr commented on June 11, 2024

Great idea, @chris-prener. I've opened a new dev_round_output branch and commit to add the suggested round_output argument to the functions. The default is FALSE, no rounding.

The branch passes CRAN checks, but feedback about the new round_output argument, structure, and documentation is welcomed.

from ndi.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.