Add powder addition kernel [!12 merged] about malamute HOT 23 CLOSED

CIVET encountered an error retrieving branch jianw/malamute:ded_mass.

This is typically caused by moosetest not having access to the repository.

Please grant Developer access to moosetest and try again.

from malamute.

In GitLab by @jiangwen84 on Oct 18, 2022, 14:59

@cticenhour Hi Casey, Luis need this kernel. Could you review it? Thanks.

from malamute.

In GitLab by @jiangwen84 on Oct 18, 2022, 15:04

added 1 commit

• 02e7f6b2 - add powder addition kernel

Compare with previous version

from malamute.

Job Documentation on 3801cfa wanted to post the following:

View the site here

This comment will be updated on new commits.

from malamute.

CIVET Testing summary for 02e7f6b

Precheck : Passed
Documentation : Passed
Mac Test : Failed : Test malamute
Test : Failed : Test malamute
Test Debug : Failed : Test malamute (debug)
Non unity build : Passed
Coverage : Canceled by user

from malamute.

In GitLab by @jiangwen84 on Oct 18, 2022, 15:56

added 1 commit

• 408f0dcc - add powder addition kernel

Compare with previous version

from malamute.

In GitLab by @cticenhour on Oct 18, 2022, 16:04

No problem - I should be free to review tomorrow morning.

from malamute.

Job Coverage on 3801cfa wanted to post the following:

Coverage

Diff coverage report

Full coverage report

This comment will be updated on new commits.

from malamute.

CIVET Testing summary for 408f0dc

Precheck : Passed
Documentation : Passed
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Passed
Coverage : Passed

from malamute.

In GitLab by @cticenhour on Oct 19, 2022, 08:21

Commented on doc/content/source/kernels/LevelSetPowderAddition.md line 1

# LevelSetPowderAddition

Please make the heading the name of the object. If you want to add the previous header somewhere to make the purpose of the object even more clear, I would add it in the text.

from malamute.

In GitLab by @cticenhour on Oct 19, 2022, 08:21

Commented on doc/content/source/kernels/LevelSetPowderAddition.md line 7

In the level set evolution equation, the free surface growth velocity due to the powder addition is given as [!citep](Morville2012),

from malamute.

In GitLab by @cticenhour on Oct 19, 2022, 08:21

Commented on test/tests/melt_pool_mass/tests line 8

    requirement = 'The system shall evolve the level set variable field with the velocity due to the powder addition.'

We should use "The system" here, as a result of suggestions from prior auditors for MOOSE and the other apps.

from malamute.

In GitLab by @cticenhour on Oct 19, 2022, 08:21

A few minor changes - have yet to check the rendering of this on the website, so might add a comment or two after that shortly.

from malamute.

In GitLab by @cticenhour on Oct 19, 2022, 08:24

Commented on doc/content/source/kernels/LevelSetPowderAddition.md line 10

You should note what D_m is in the text as well. Also, I assume r is radius? If not, please clarify that as well.

from malamute.

In GitLab by @jiangwen84 on Oct 19, 2022, 08:36

Commented on doc/content/source/kernels/LevelSetPowderAddition.md line 1

changed this line in version 4 of the diff

from malamute.

In GitLab by @jiangwen84 on Oct 19, 2022, 08:36

Commented on doc/content/source/kernels/LevelSetPowderAddition.md line 7

changed this line in version 4 of the diff

from malamute.

In GitLab by @jiangwen84 on Oct 19, 2022, 08:36

Commented on test/tests/melt_pool_mass/tests line 8

changed this line in version 4 of the diff

from malamute.

In GitLab by @jiangwen84 on Oct 19, 2022, 08:36

added 1 commit

• 3801cfa - add powder addition kernel

Compare with previous version

from malamute.

In GitLab by @jiangwen84 on Oct 19, 2022, 08:43

resolved all threads

from malamute.

In GitLab by @jiangwen84 on Oct 19, 2022, 08:43

@cticenhour thanks! I addressed all your comments.

from malamute.

CIVET Testing summary for 3801cfa

Precheck : Passed
Documentation : Passed
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Passed
Coverage : Passed

from malamute.

In GitLab by @cticenhour on Oct 19, 2022, 10:25

approved this merge request

from malamute.

In GitLab by @cticenhour on Oct 19, 2022, 10:25

mentioned in commit 145b86a

from malamute.