How to test when exit() is called? about spectator HOT 8 CLOSED

Heads up, this is changing in v0.11. Instead of relying on stubs, exit will raise a Spectator::SystemExit error. This mimics what RSpec does. See the related spec for this issue for an example.

from spectator.

It seems that Spectator isn't stubbing the exit method. There needs to be a stub defined prior to calling receive(:exit). For instance:

class SomeClass
  def goodbye
    exit
  end
end

mock SomeClass do
  stub exit
end

it "captures exit" do
  expect(subject).to receive(:exit).with(0)
  subject.goodbye
end

This code doesn't work though, since exit isn't defined in SomeClass - it's a top-level method. Another issue is that a type is required for the mock block, but there isn't one for a top-level method. (maybe Object?)

Do you have any code that shows this in action in RSpec?

from spectator.

Code: https://github.com/postmodern/command_kit/blob/a06a131ddde42fa7f7730debbdc66136282bae1f/lib/command_kit/main.rb#L46-L56
RSpec specs: https://github.com/postmodern/command_kit/blob/a06a131ddde42fa7f7730debbdc66136282bae1f/spec/main_spec.rb#L28-L100

from spectator.

This should be possible in v0.9.39 - Can you try it out and confirm?

The following spec works:

require "../spec_helper"

Spectator.describe "GitHub Issue #29" do
  class SomeClass
    def goodbye
      exit 0
    end
  end

  mock SomeClass do
    stub exit(code)
  end

  describe SomeClass do
    it "captures exit" do
      expect(subject).to receive(:exit).with(0)
      subject.goodbye
    end
  end
end

from spectator.

Ah, stubbing/capturing exit now works on instances, but not at the class-level. I'm guessing mock/stub is assuming exit is an instance method?

require "./spec_helper"

Spectator.describe "test exit" do
  class Foo
    def self.test
      exit 0
    end
  end

  mock Foo do
    stub exit(code)
  end

  subject { Foo }

  it "must capture exit" do
    expect(subject).to receive(:exit).with(0)

    subject.test
  end
end

$ crystal spec spec/test_spec.cr 
test exit

from spectator.

I think I see why this is happening. I'll try to get a fix in.

from spectator.

Should be resolved in v0.9.40, can you verify?

For class methods that call exit, it will need to stub self.exit(code).

from spectator.

Confirmed self.exit(code) works.

from spectator.