Error on upgrading to Crystal 0.36.0 about spectator HOT 4 CLOSED

I'm surprised this worked before. In this syntax:

it is_expected.to be_nil

there's no block, and the macro code is asking for the filename and line number of the non-existent block. You're correct in that surrounding the test with braces would fix it, since that introduces a block.

it { is_expected.to be_nil }

There will be a fix for this shortly.

I had planned to deprecate the brace-less syntax in the next version of Spectator. However, I've seen quite a few people using this syntax and am having second thoughts. This syntax isn't supported in RSpec (for probably obvious reasons), but it can look quite elegant. What are your thoughts?

from spectator.

It seems that either something changed in the Crystal compiler (Nop used to have non-nil source values) or this broke in the last Spectator update, which aligns somewhat with the release of Crystal 0.36.0. This change switched from using __FILE__ and __LINE__, since they were unreliable in macros, to using the block's AST data. Do you know when this broke exactly? If I had to guess, it was the last version of Spectator that caused the issue. Either way, not too important, it's fixed now 😄

from spectator.

This is my first time using spectator so I'm probably not the best person to ask for an opinion about this shard.

My opinion would be to remove that style of spec. My first thought after tracking down the problem specs was that they probably never worked correctly but I think you're saying that they used to.

from spectator.

Fixed by 8d48e44

from spectator.