Code Monkey home page Code Monkey logo

Comments (4)

dgrunwald avatar dgrunwald commented on July 24, 2024

This affects more than just 'null' - for example, take two method signatures (string, object) and (object, string), and a call ("Hello", "World") - the decompiler will have to detect that overload resolution would not produce the desired result, and then insert casts where necessary.

from ilspy.

dsrbecky avatar dsrbecky commented on July 24, 2024

A simple solution would be to use casts whenever there is more then one overload. Or whenever there is more then one one applicable overload. I would not go as far as implementing "betterness".

from ilspy.

dgrunwald avatar dgrunwald commented on July 24, 2024

NRefactory already implements applicability testing, "betterness" (see OverloadResolution.BetterFunctionMember) and reports ambiguities.
We just need to translate from the Cecil type system to the NRefactory type system and reuse that implementation.
NRefactory even implements type inference, so we can avoid explicitly specifying type arguments when it's not necessary.

from ilspy.

richardschneider avatar richardschneider commented on July 24, 2024

I've changed the AstMethodBodyBuilder.TransformCall method to cope with this issue. How do a send you the patch file?

Perhaps, I made the change at too low a level. I'll look at BetterFunctionMember.

from ilspy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.