Comments (5)
Hey @luke-unifymonitor this key warning is fixed in 2.1.4
. Here is the updated code sandbox: https://codesandbox.io/s/13j7vr75yl
from react-router-breadcrumbs-hoc.
π hey @luke-unifymonitor!
note: I removed my previous comment because I just had a chance to try out this approach below and it seems like it might work well for this use case.
Instead of a string, I recommend using a component breadcrumb that checks if the param is included or not:
const RegisterSensorBreadcrumb = ({ match }) => {
// if the route includes `hubId` then return nothing for that breadcrumb
// (alternatively you could also render a different breadcrumb IF the hubId is provided)
if (match.params.hubId) { return null; }
// if the route does NOT include `hubId` then return normal Register Sensor breadcrumb
return <span>Register Sensor</span>;
};
const routesConfig = [
{
path: '/sensor/register/:hubId?',
exact: true,
component: RegisterSensorContainer,
breadcrumb: RegisterSensorBreadcrumb,
}
];
// /sensor/register == 'Register Sensor'
// /sensor/register/123 == 'Register Sensor'
In this case both /sensor/register
and /sensor/register/123
paths will result in / Register Sensor
.
Let me know if this works for you!
from react-router-breadcrumbs-hoc.
Gonna close this as the suggestion above should solve for this use case. If it doesn't, just let me know and I'll reopen this. Thanks!
from react-router-breadcrumbs-hoc.
Hi @icd2k3,
Apologies for not replying before. We had a re-think for the application and no longer needed the paths that caused the problem.
However, I did create this https://codesandbox.io/s/kok304yz1v and the console reads:
Warning: Encountered two children with the same key,
/sensor/register/:hubId?
. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted β the behavior is unsupported and could change in a future version.
Many thanks for your help.
from react-router-breadcrumbs-hoc.
π€ I should fix that warning. I'll look into this case in the near future.
Thanks for the reply and the code sandbox @luke-unifymonitor !
from react-router-breadcrumbs-hoc.
Related Issues (20)
- Translated breadcrumbs (delaying routes init) HOT 1
- dassad
- Unnecessary peer dependency on react-router-dom HOT 4
- "//" produces double matches HOT 1
- Unable to pass additional props. HOT 3
- define breadcrumbβs description HOT 2
- Disabling default generated breadcrumbs by passing breadcrumb: null raises an error HOT 2
- Property 'match' does not exist on type 'ReactNode' HOT 1
- What to use instead of InjectedProps HOT 3
- Replacing react-router with react-router-dom HOT 2
- Fixed
- Suppress autmatically added Home Breadcrumb HOT 2
- Issue with excludePaths not being consistent with breadcrumbs: null HOT 6
- Question about type definition HOT 3
- typescript definition mistake HOT 1
- How do I add in between crumbs ? HOT 2
- Question: Is there a way to not export the current page in breadcrumbs HOT 2
- Question: breadcrumbs propTypes HOT 1
- How to remove "-" from titles HOT 3
- react-router v6 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-router-breadcrumbs-hoc.