Comments (7)
Hey @nachoaIvarez, thanks for the suggestion! At initial glance I think it sounds like a good improvement idea!
One concern:
Users might not want to render a breadcrumb from some route segments. In this case we'd need some kind of opt-out option if each segment automatically returns a default string.
I should have some time within the next couple weeks to try this idea on my end. In the meantime I'd be happy to take a look at a PR as well!
from react-router-breadcrumbs-hoc.
FYI this is now included as part of 2.0.0
along with some other core changes listed here
from react-router-breadcrumbs-hoc.
Example:
teams/:teamId/roster-and-staff
> Teams / 984752985 / Roster and staff
That should be by default.
And, if instead of showing the ID you want to show the team name, you can still use the routes
param in the HOC:
export default withBreadcrumbs({
'teams/:teamId': ({ match }) => <span>{teams[match.params.userId].name}</span>
})(Breadcrumbs)
teams/:teamId/roster-and-staff
> Teams / Actual Team Name / Roster and staff
You have the same result with way less configuration than the currently needed.
from react-router-breadcrumbs-hoc.
@nachoaIvarez I have a rough working branch for this so don't worry about a PR - I'll get this cleaned up and released in the near future
from react-router-breadcrumbs-hoc.
from react-router-breadcrumbs-hoc.
Nps, thanks for making the suggestion! As a heads up, it may be a week or so before I can get it all merged up and released as I'm a bit busy with work at the moment. Thinking this change will also bump the package to 2.0 so I want to make sure I have the test cases covered + good documentation. I'll post back here once it drops!
from react-router-breadcrumbs-hoc.
This is great @icd2k3. Thank you so much.
from react-router-breadcrumbs-hoc.
Related Issues (20)
- Translated breadcrumbs (delaying routes init) HOT 1
- dassad
- Unnecessary peer dependency on react-router-dom HOT 4
- "//" produces double matches HOT 1
- Unable to pass additional props. HOT 3
- define breadcrumb‘s description HOT 2
- Disabling default generated breadcrumbs by passing breadcrumb: null raises an error HOT 2
- Property 'match' does not exist on type 'ReactNode' HOT 1
- What to use instead of InjectedProps HOT 3
- Replacing react-router with react-router-dom HOT 2
- Fixed
- Suppress autmatically added Home Breadcrumb HOT 2
- Issue with excludePaths not being consistent with breadcrumbs: null HOT 6
- Question about type definition HOT 3
- typescript definition mistake HOT 1
- How do I add in between crumbs ? HOT 2
- Question: Is there a way to not export the current page in breadcrumbs HOT 2
- Question: breadcrumbs propTypes HOT 1
- How to remove "-" from titles HOT 3
- react-router v6 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-router-breadcrumbs-hoc.