Code Monkey home page Code Monkey logo

Comments (2)

boneskull avatar boneskull commented on July 18, 2024

I think this is related to #26

Essentially, the tests are running some stuff via modules, and other stuff via dist files. Because of this rule, we're avoiding loading ES modules when we do e.g., import foo from '@report-toolkit/common'. But in the tests, we load ES modules directly and shim via esm`.

admittedly, these aren't things that should be mixed and matched, but it was the quickest way to get some unit tests written using ESM.

I was not able to configure esm to use module as a mainFields item (we get some other errors coming out of unexpected). If we can get that to work, it wouldn't require a change to our codebase, since import foo from '@report-toolkit/common' will look into the package's module field, which will load the correct source module.

The issue may actually be in unexpected-rxjs as it looks like the error coming out of unexpected is related to plugins.

from report-toolkit.

boneskull avatar boneskull commented on July 18, 2024

another issue is that the e2e cli tests should use the actual distfile, which will also potentially cause coverage weirdness.

nyc is able to understand, but codecov isn't. maybe a mapping is needed in the codecov.yml? don't know

from report-toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.