Logs --follow process times out after 4 minutes about ffdl HOT 4 CLOSED

@ckadner Apologies for the late response, as I've been on vacation.

The lines in question as part of a larger commit that changed how GetTrainedModelLogs works. I traced the original DLaaS commit, from your's truly, and I think my intention was to not rely on a long term stream being held open, but to be able to re-open a new stream starting from where the old left off, if the connection terminates. But I think the

		ctx, cancel := context.WithTimeout(context.Background(), time.Minute * 4)
		defer cancel()

section needs to be moved to inside the for loop just above

query := trainedModelLogRequestToTrainerQuery(req, rindex, oldEndpointInternalPageSize)

So, before we merge #107, can you give this a try first, to see if it's a better solution?

from ffdl.

@ckadner will you get a chance to try ^^^ today?

from ffdl.

@sboagibm -- your suggested fix appears to work. I will update this PR accordingly.

from ffdl.

Closed with #107

from ffdl.