Code Monkey home page Code Monkey logo

Comments (4)

boyceg avatar boyceg commented on June 12, 2024

I'm not sure. I would suggest trying to make a test to see if there is an error before changing it. The sign conventions that are implemented can be a little obscure...

from ibamr.

amneetb avatar amneetb commented on June 12, 2024

Hmm, ok.

However, this one looks like a definite bug

https://github.com/IBAMR/IBAMR/blame/master/src/navier_stokes/StaggeredStokesPETScLevelSolver.cpp#L316

It undoes all the modifications done to the RHS vector, by re-copying the original unmodified vector b to petsc_b.

from ibamr.

boyceg avatar boyceg commented on June 12, 2024

Can you point me to the code lines in question? You are linking to the change log here I think.

from ibamr.

amneetb avatar amneetb commented on June 12, 2024

This one:

https://github.com/IBAMR/IBAMR/blob/master/src/navier_stokes/StaggeredStokesPETScLevelSolver.cpp#L316

from ibamr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.