Comments (3)
Damn, I agree with you. Open to ideas/PRs!
from slate-plugins.
How about a simple file.type
? https://developer.mozilla.org/en-US/docs/Web/API/File/type - According to docs the browser will look at extension, which isn't fool-proof, of course, but it'll reduce the bundle size by 90% and will work most of the time.
Alternatively we could use a byte reader to get the "magic numbers" which will be more accurate but will require a bit more work to get going: https://medium.com/the-everyday-developer/detect-file-mime-type-using-magic-numbers-and-javascript-16bc513d4e1e https://codepen.io/movii/pen/oBLNoJ
I'd be happy to make a PR for either, just would like to know what you'd think the appropriate scope of abilities for this plugin should be (focus on Slate logic and basic filetype detection or a bit more complex logic outside of Slate with a more solid file type detection).
Thanks @ianstormtaylor !
from slate-plugins.
Nice, yeah I'm down with the file.type
, that sounds easiest. Thank you!
from slate-plugins.
Related Issues (20)
- include a renderNode function in PasteLinkify plugin? HOT 1
- AutoSave plugin HOT 1
- Auto-replace Example Broken HOT 2
- Demo Broken HOT 1
- Images HOT 1
- Cannot paste slate data fragments if using slate-drop-or-paste-images
- Consider using ESLint rule: default-case
- Live demo is broken HOT 1
- Produces a Slate error on image paste HOT 10
- Could not get Autoreplace to work HOT 1
- slate-auto-replace logs deprecation message with slate 0.44
- slate-drop-or-paste-images: Error is thrown if file has no extension HOT 1
- slate-soft-break: Newline inserted just after a mark misplace the cursor HOT 2
- Auto Replace and Collapse on Escape not working in example page. HOT 4
- Wrong handler onInsertText in slate-drop-or-paste-images
- Auto-Replace Add Mark Bug. HOT 1
- slate-soft-break: insert soft break on paste
- Link in bullet list continues in the next list item
- Are these scheduled for merging or... HOT 2
- React Application Compilation Error With slate-drag-drop-or-paste-images
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from slate-plugins.